Skip to content

Conversation

myk002
Copy link
Member

@myk002 myk002 commented Jul 29, 2020

DFHack/dfhack#499 Implement the quickfort set command and reading from the dfhack-config/quickfort/quickfort.txt config file

Copy link
Member

@lethosor lethosor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just to confirm, this only supports changing settings in-memory (i.e. they don't persist), right?

@myk002
Copy link
Member Author

myk002 commented Jul 29, 2020

yes, just setting them in memory. I note in the help text that changes made with quickfort set only apply to the current session and are not persistent.

@lethosor
Copy link
Member

The help text was already present from an older PR, so I missed it :)

@lethosor lethosor merged commit c3976ea into DFHack:quickfort Jul 29, 2020
@myk002 myk002 deleted the quickfort_set branch July 29, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants