quickfort xslx support #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, this PR is clear for merge once xlsxreader is merged in DFHack/dfhack#1620 |
lethosor
reviewed
Aug 17, 2020
internal/quickfort/list.lua
Outdated
| @@ -28,7 +28,7 @@ local function scan_csv_blueprint(path) | |||
| blueprint_cache[path] = {modeline=get_modeline(filepath), mtime=mtime} | |||
| end | |||
| if not blueprint_cache[path].modeline then | |||
| print(string.format('skipping "%s": no #mode marker detected', v.path)) | |||
There was a problem hiding this comment.
Good catch, I caught this locally but forgot to comment yesterday
lethosor
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DFHack/dfhack#499
use the API and libraries in DFHack/dfhack#1620 to implement reading blueprints from xlsx files. Refactor the blueprint reading logic to handle both csv and xlsx input.
also rename the sheet parameter from -s|--sheet to -n|--name to support more general naming in the future (I'm thinking ahead for multiple blueprints sections per csv file or spredsheet sheet)