-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[driver] sqla results are not dict-like anymore #296
Conversation
Bugs prevented by |
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 98.67% 98.68%
=======================================
Files 48 49 +1
Lines 2193 2207 +14
Branches 292 304 +12
=======================================
+ Hits 2164 2178 +14
Misses 19 19
Partials 10 10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Behavior changes:
|
Yikes, @dionhaefner, those issues with SQLite files not getting released have haunted me before - on Linux, though. https://github.com/DHI-GRAS/terracotta/actions/runs/4055501441/jobs/6978731806#step:11:588 Never got to dig deeper because we migrated to use MySQL everywhere. Wonder how you can force the underlying SQLite library to release the file, like https://stackoverflow.com/a/12679840/512111 (C#) or https://stackoverflow.com/a/59483095/512111 or https://stackoverflow.com/questions/6134980/file-locks-in-sqlite... |
Hallelujah. |
See https://pydoc.dev/sqlalchemy/latest/sqlalchemy.engine.row.Row.html
Fixes #295