Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong wing cell generation of the lower shell #930

Closed
hardt-fa-flb opened this issue Oct 18, 2022 · 1 comment · Fixed by #931
Closed

Wrong wing cell generation of the lower shell #930

hardt-fa-flb opened this issue Oct 18, 2022 · 1 comment · Fixed by #931
Assignees

Comments

@hardt-fa-flb
Copy link

The creation of the wing cells of the lower shell is wrong. In this CPACS-file there are several wing cells defined along the chord, but the trailing boundary of all TIGL generated cell shapes is the trailing edge:

grafik

@joergbrech joergbrech self-assigned this Oct 19, 2022
@joergbrech
Copy link
Contributor

joergbrech commented Oct 24, 2022

Thanks for opening an issue! I can reproduce your problem. As expected, the problem is in the logic of converting the internal parametrization of the faces of the wing to contour coordinates:

The internal parameters in chordwise direction start at the lower part of the trailing edge and end at the upper part of the trailing edge. Contour coordinates always start at the leading edge and end at the trailing edge. Therefore, on the lower skin, the contour coordinate parametrization has a different sign than the internal parametrization. This and the fact, that the wing could potentially already be a patchwork of many faces, that do not coincide with the cell faces makes the internal trimming logic a bit complicated and error prone.

That begin said, I think I found the conversion error and can generate the blade fine now:
image

joergbrech added a commit that referenced this issue Oct 24, 2022
joergbrech added a commit that referenced this issue Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants