HiddenStats ??

[Timo-Breumelhof]

Please summarize your question in one sentence

The main template contains a hidden span containing this:

<span class="afhiddenstats">2 Topics and 2 Replies and 0 Subscribers</span>

Give a more extended description

I have no idea WHY that's in there as it's essentially a repetition of this, a few lines later.
And it's hidden using CSS.

<span class="af-colstats_responsive">
	<i class="fa fa-files-o fa-fw fa-grey"></i>&nbsp;[TOTALTOPICS] 
	<i class="fa fa-reply fa-fw fa-grey"></i>&nbsp;[TOTALREPLIES]
	<i class="fa fa-envelope-o fa-fw fa-grey"></i>&nbsp;[FORUMSUBSCRIBERCOUNT]
</span>

In full:

<table>
		<tr>
			<td rowspan="2" class="afsubject">
				<span class="afhiddenstats">[TOTALTOPICS] [RESX:TOPICSHEADER] and [TOTALREPLIES] [RESX:REPLIESHEADER] and [FORUMSUBSCRIBERCOUNT] [RESX:SUBSCRIBERS]</span>
				<span class="aftopictitle">[FORUMNAME]</span>
				<span class="af-colstats_responsive">
					<i class="fa fa-files-o fa-fw fa-grey"></i>&nbsp;[TOTALTOPICS] 
					<i class="fa fa-reply fa-fw fa-grey"></i>&nbsp;[TOTALREPLIES]
					<i class="fa fa-envelope-o fa-fw fa-grey"></i>&nbsp;[FORUMSUBSCRIBERCOUNT]
				</span>
				<span class="aftopicsubtitle">[FORUMDESCRIPTION]</span>
				<div class="af_lastpost_responsive" style="white-space:nowrap;">[LASTPOSTSUBJECT:25]<br />[RESX:BY] [DISPLAYNAME]<br />[LASTPOSTDATE]</div>
			</td>
		</tr>
	</table>

I guess it can be removed in the updated template, right?
Opinions?

@WillStrohl @johnhenley ?

[johnhenley]

I wondered the same thing when I was working on #238, and I just added the subscriber counts to the existing structure.
To me, it looks like the stats columns are duplicated because there is a "responsive" version that is perhaps not shown on smaller devices? And the "hidden" stats are there for search engines?

I dug way back into the former code repository and found that this was added here:
ActiveForums/ActiveForums@a181c91#diff-10b79cc39b760b9073a428381780921e4d7992f586131753f4dde80e80f009c6

It makes no sense to me, since display:none doesn't remove it from the markup so it would still be visible to a search engine. I think we can clean it up if you want.

[Timo-Breumelhof]

I agree, I'll clean it up

[johnhenley]

I agree, I'll clean it up

Let me know when you do, since we also need to change the af_grid.cs.ascx/af_grid.cs code a little bit I think.

[Timo-Breumelhof]

Fixed with #501

[johnhenley]

@Timo-Breumelhof did you mean to close this one? Don't we still need to fix it, at least at some point? There is code here that needs to be updated as well:

[Timo-Breumelhof]

@johnhenley my issue was about the "afhiddenstats" css class.
I removed from both module.css and the new template
I think removing the responsive class from anything else than the templates might break v7 Themes?
Maybe do this for v 9?

[johnhenley]

Should I reopen as a placeholder since it has the context of what new to be addressed?

[Timo-Breumelhof]

@johnhenley I'm fine with that and we put everything we find related legacy class related in here?

[johnhenley]

Re-opening to work on this in future release.