Fix file permissions when GitLab CI clones the repository #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
Oct 4, 2022
|
Thanks I will build new docker images. |
tom93
added a commit
to tom93/domjudge-packaging
that referenced
this pull request
May 17, 2023
CI_PRE_CLONE_SCRIPT is deprecated and will be removed in GitLab 16.0 (see [1]). We use it to disable "umask 0000", which can also be done using FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR (see [2]), so switch to that. Also add a regression test. (When I was implementing the original fix using CI_PRE_CLONE_SCRIPT in DOMjudge#137, I did also try FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR, but it didn't seem to work. It works fine now; I think the issue at the time was due to caching, see [3].) [1]: https://docs.gitlab.com/ee/update/deprecations?removal_milestone=16.0&breaking_only=true#deprecation-and-planned-removal-for-ci_pre_clone_script-variable-on-gitlab-saas [2]: https://www.gitlab.com/gitlab-org/gitlab-runner/-/issues/1736#note_1370906098 [3]: https://www.gitlab.com/gitlab-org/gitlab/-/issues/300715
nickygerritsen
pushed a commit
that referenced
this pull request
May 17, 2023
CI_PRE_CLONE_SCRIPT is deprecated and will be removed in GitLab 16.0 (see [1]). We use it to disable "umask 0000", which can also be done using FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR (see [2]), so switch to that. Also add a regression test. (When I was implementing the original fix using CI_PRE_CLONE_SCRIPT in #137, I did also try FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR, but it didn't seem to work. It works fine now; I think the issue at the time was due to caching, see [3].) [1]: https://docs.gitlab.com/ee/update/deprecations?removal_milestone=16.0&breaking_only=true#deprecation-and-planned-removal-for-ci_pre_clone_script-variable-on-gitlab-saas [2]: https://www.gitlab.com/gitlab-org/gitlab-runner/-/issues/1736#note_1370906098 [3]: https://www.gitlab.com/gitlab-org/gitlab/-/issues/300715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://gitlab.com/gitlab-org/gitlab-runner/-/issues/1736