Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[DS-3755] integration test for submission configuration endpoint #1929
tdonohue left a comment
Overall, this is looking good. But, after giving this a quick scan, I believe all my questions/suggestions from the previous PR (#1889) have not yet been implemented. I found the same code in this new PR.
That said, none of my comments should necessarily block this PR. But, I do feel there are minor refactors and additional comments that should be made. I also still don't much like the new class name
I just ended with the suggestions. I hope that this go well. I tried to do a simple javadoc, also because I have some limitation with the english :)