DS-1917 JSPUI validity fixes (several non-controversial fixes) #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If these are non-controversial, they probably should just be merged for 5.0 |
helix84
added a commit
that referenced
this pull request
Aug 14, 2014
DS-1917 JSPUI validity fixes (several non-controversial fixes)
corrad82-4s
pushed a commit
to 4Science/DSpace
that referenced
this pull request
May 10, 2023
Epfl DSC-719
kosarko
added a commit
to kosarko/DSpace
that referenced
this pull request
Mar 28, 2024
* ufal/downloading-restricted-bitstreams-not-working-properly (DSpace#457) * The admin could download restricted bitstreams. * The user cannot download bitstream if he/she is not signed in. * Cannot obtain context with user. * The user is already fetched from the context. * Added docs. * Do not use endpoint for downloading the single file because it already exists - remove it. * Fixed AuthorizationRestControllerIT tests. * ufal/be-cannot-download-and-preview-files-after-migration (DSpace#454) * Find bitstream format using mimetype not ID. * Updated tests according to fix. * ufal/update-canonical-prefix-to-hdl (DSpace#460) * Updated `handle.canonical.prefix` to hdl handle. * Integration test cannot have changed handle.canonical.prefix. * ufal/be-user-registration-missing (DSpace#463) * The user registration is added when the eperson is created by the ui. * try using newer checkout, same as upstream, since error is with git --------- Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * ufal/be-license-download-statistics (DSpace#462) * Add logging of downloading restricted bitstreams. * Log downloading of every bitstream not only restricted ones. * Added docs * Refactored logging. * ufal/be-shibboleth-headers-encoding (DSpace#464) * givenname and last name values are converted to UTF-8 encoding * Delete eperson in tests * using our dspace-dependencies because of dataquest-dev#466 * ufal/be-fix-email-parameters Fixed emails sending - added arguments and cfg properties that are sent in the email. (DSpace#470) * ufal/be-provenance-subbmitter-missing (DSpace#469) * DSpace#8585 Add submitter information to provenance metadata * Cherry picked fix from vanilla and added test to check if the Item provenance metadata is added --------- Co-authored-by: Adán Román Ruiz <aroman@arvo.es> * ufal/be-get-user-ip-address (DSpace#468) * Created endpoint for fetching IP address with tests. * Made the code more understable * ufal/publisher-ok-fix (DSpace#473) * fixes ufal#1096 (DSpace#471) * Added publisher filter in the integration test check --------- Co-authored-by: Ondřej Košarko <ko_ok@centrum.cz> * ufal/zip-preview-configurable (DSpace#475) * Made previewing of the file configurable. * The default value of the previewing the file must be true in the integration tests. * ufal/fe-oversized-file-upload-message Exposed max file limit for upload from the cfg. (DSpace#477) * ufal/be-email-restricted-download * Fixed comments in the clarin emails (DSpace#484) * ufal/be-not-show-shib-welcome-page (DSpace#485) * Added cfg property to enable/disable showing of the page with attributes passed from the idp. * ufal/be-s3-customization (DSpace#481) * The bitstream data are stored in to local store after uploading to S3 * The bitstream is removed from the S3 and local assetstore * Store number is specific if all storages are synchronized. * Return store number in the BitstreamRest object * Find out which store is used - it could be synchronized stores number. * Constant is moved to the Bitstream class * Synchronization of storages is not allowed by default - set up it in the test environment. * Added docs * Removed constant from the Bitstream class - it wasn't consistent * Overriden BitstreamStorageServiceImpl by custom SyncBitstreamStorageServiceImpl * Removed ClarinS3BitStoreService.java to SyncS3BitStoreService * Added doc and refactoring. * ufal/be-s3-checker-sync (DSpace#486) * Fixed UserCheck - There was created a wrong select * Fixed ChecksumCheck - the session was closed but there were some requests do the database then * internal/load-version-from-file (DSpace#488) * Load version from the specific file and show content in the root endpoint. * Fixed checkstyle issue * DO not log anything if the VERSION file does not exist. Added VERSION file path into cfg property. * Append every line into final String. * ufal/be-s3-checksum-fix (DSpace#487) * Cherry picked fix S3 optimalization fixes from Vanilla * Cherry picked adding of pagination on cleanup * Updated Sync services according to S3 optimization fix * The checksum value is compared between S3 and local assetstore and the new result is inserted to the database. * Added docs and refactoring * The checksum values are exposed by REST API * Fixed failing tests --------- Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Luca Giamminonni <luca.giamminonni@4science.it> * internal/versioning (DSpace#491) * add version to docker * Allow shell because it is using double quotes in the command string. * removed cat and ls commands --------- Co-authored-by: MajoBerger <marian.berger@dataquest.sk> * ufal/comment-ever-failing-test * Commented still failing tests (DSpace#490) * internal/verion-update-path (DSpace#492) * Updated `build.version.file.path` because the server cannot find `VERSION_D.txt` file * Added VERSION_D.txt info `.gitignore` * User ${dspace.dir} instead of absolute path * internal/be-upgrade-clarin-dspace-7.6 (DSpace#497) * Split docker image builds into separate jobs to allow them to run in parallel. * Ensure 'main' code is tagged as 'latest' in DockerHub * Fixes DSpace#8558 - set Solr UTC timezone Set the timezone of the Solr date formatter to UTC * remove obsolete code fragments * Add action to automatically create a port PR when specified (cherry picked from commit f6a898c) * Run PR Port action as 'dspace-bot' to allow new PRs to trigger CI checks * Minor update to label_merge_conflicts to ignore any errors (seem random at this time) * Fix typo. Config must be a valid regex (cherry picked from commit 7995289) * Bump h2 from 2.1.214 to 2.2.220 Bumps [h2](https://github.com/h2database/h2database) from 2.1.214 to 2.2.220. - [Release notes](https://github.com/h2database/h2database/releases) - [Commits](h2database/h2database@version-2.1.214...version-2.2.220) --- updated-dependencies: - dependency-name: com.h2database:h2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update FullTextContentStreams.java Fix NPE if bitstream is null * Update FullTextContentStreams.java Add additional NPE checks * Update ItemUtils.java Prevent npe if bitstream is null * dspace.cfg: remove old webui.itemlist properties These properties are no longer used in DSpace 7: webui.itemlist.widths webui.itemlist.*.widths webui.itemlist.tablewidth (cherry picked from commit 16c46c4) * dspace.cfg: remove old webui.browse.thumbnail.show property The webui.browse.thumbnail.show property is no longer used as of DSpace 7. Also remove subsequent references to adding thumbnails to item view columns since these are from legacy DSpace. (cherry picked from commit 213a546) * dspace.cfg: remove old webui.itemlist.browse.* property The webui.itemlist.browse.* properties are no longer used in DSpace 7. (cherry picked from commit 35f72bc) * Fix DSpace#8963: Remove deletion constraint from Groomer * Enable entity type to submission form mapping by default (cherry picked from commit b71eee8) * [DURACOM-179] replaced 'null' value with exception actual value in sendErrorResponse method calls having 'null' (cherry picked from commit aa35a47) * DS-8935. webui.browse.link CrossLinks - Fix for multiple exact matches Fixes DSpace#8935 when multiple exact match "webui.browse.link" configuration entries are present that point to different indexes. Modified the code to return the index associated with the given metadata (which is used as the key in the hash map), instead of the key from the keySet (which may not actually be the metadata value being searched for). DSpace#8935 (cherry picked from commit b846c53) * DSpace#9006 fix referenced configuration file (cherry picked from commit 29a88d7) * DSpace#9006 fix referenced configuration file (Test) (cherry picked from commit 309b0b3) * Fix DSpace#8933: Only add the base statistic core if it hasn't already been added * Remove duplicate code * On failure log the name of the assetstore file and trace causes of exception. (cherry picked from commit 22974e9) * Report Throwable's type too. (cherry picked from commit d6b612f) * More description on OutOfMemoryError too. (cherry picked from commit bbe5df3) * Remove useless log.info (cherry picked from commit 1f3ad99) * 103837: Refactor GA config to list bundles * README.md: Fix typo (cherry picked from commit ca8abdd) * Bump up versions of buildnumber-maven-plugin & build-helper-maven-plugin. add configuration for SCM failure (cherry picked from commit 78ea9e8) * 3331 - remove the --optimize feature of 'dspace stats-util' (cherry picked from commit 08c6509) * fix MissingOptionException on help (cherry picked from commit 8ae5ffb) * fix stylecheck (cherry picked from commit b1377ca) * ingore unrecognized arguments on help (cherry picked from commit 82c9b6f) * add DSpaceSkipUnknownArgumentsParser as parser to ignore/skip unknown arguments in cli by help, fix not necessary ParseException in help (cherry picked from commit 86285d7) * remove not necessary else (cherry picked from commit 064e2ca) * Enable new skip merge commit feature * dspace-api: remove unnecessary trailing whitespace * 103818 ItemServiceImpl#inheritCollectionDefaultPolicies now clears item READ policies if new parent collection has a default READ policy * 103818 Add boolean parameter to ItemServiceImpl#inheritCollectionDefaultPolicies to decide whether to override item read policies * 103818 Add boolean parameters to ItemServiceImpl methodds to decide whether to override read policies * 103818 Extend ItemServiceTest#testMoveItemToCollectionWithMoreRestrictiveReadPolicy * 104878 Fix error in ItemServiceTest related to inheriting collection policies upon item move * 104878 Adjust ItemServiceTest to expect correct behavior of bundles when item is migrated * Fix failing IT in BulkAccessControlIT * 103837: Fix isContentBitstream() in GoogleAsyncEventListener * Rename test suites that are really integration testing. (cherry picked from commit f66ca33) * Bump org.eclipse.jetty:jetty-xml Bumps [org.eclipse.jetty:jetty-xml](https://github.com/eclipse/jetty.project) from 9.4.51.v20230217 to 9.4.52.v20230823. - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.51.v20230217...jetty-9.4.52.v20230823) --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-xml dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 2bcc0b3) * Add note that rebooting Tomcat required * Add websvc.opensearch.autolink and websvc.opensearch.shortname to exposed REST configuration properties (cherry picked from commit 80b35c9) * Add a "container friendly" log4j2 cfg and output compose dspace log to console (cherry picked from commit 9eefd56) * Fix ClassCastException (Collection cannot be cast to Item) in Handle identifier classes (cherry picked from commit 1271374) * Fix checkstyle. Correct grammar of comment while doing so. (cherry picked from commit ffa2683) * Avoid double slashes in sitemap paths. (cherry picked from commit eae4463) * Remove 'cross join' from count query. Updates "countHandlesByPrefix" to use a query similar to existing "findByPrefix" (cherry picked from commit 14223bd) * fix logical bug when checking if field is controlled authority * remove optimize option from oai import * added authorization check for license bitstream in OAI import * OAI: add support to extract embargo from bitstreams and expose it in OAI metadata (cherry picked from commit db81d75) * ItemUtils.java: added method doc (cherry picked from commit 51e60fb) * ItemUtils.java: improved method to account for multiple embargo policies and select the longest embargo (cherry picked from commit 538be7f) * Refactored access-status to include embargo date based on the DefaultAccessStatusHelper logic (look at primary or first bitstream) (cherry picked from commit 895926f) * Remove unused imports (cherry picked from commit 4bd2cfd) * Fix style issues (cherry picked from commit 724a4ff) * Fix style issues (cherry picked from commit 6e2c8a4) * Add null check (cherry picked from commit 0de4c39) * ItemUtils.java: refactored addEmbargoField (cherry picked from commit 291afa7) * uketd_dc.xsl: also expose access-status if embargo or restricted (cherry picked from commit 4b40872) * DefaultAccessStatusHelper: fix logic to take shortest embargo (cherry picked from commit d17ef09) * Remove currently unused customisation of ItemUtils (cherry picked from commit 490a982) * DefaultAccessStatusHelper: getEmbargoFromItem return null embargo if status than embargo (cherry picked from commit e05e73a) * Additional Item class cast fixes in handle providers DSOs were not properly checked if they were instanceof Item before attempting the cast in HandleIdentifierProvider and VersionedHandleIdentifierProviderWithCanonicalHandles * Remove Oracle script that accidentally made it in via DSpace#8800 (cherry picked from commit 5e04edf) * 8968 - request-a-copy email: non ASCII characters are encoded as HTML character entity references (cherry picked from commit db36d5e) * unused import (cherry picked from commit bf6e042) * 8968 - added custom StringEscapper (cherry picked from commit 103c8ee) * checkstyle (cherry picked from commit 2c2b3b1) * 8968 - implementated using HtmlUtils scaping (cherry picked from commit 090beed) * checkstiye (cherry picked from commit d12fbe2) * Define _version_ * DSpace#8585 Add submitter information to provenance metadata (cherry picked from commit c15ac0e) * 8585 - added provenance to metadata-import and itemImport (cherry picked from commit ea6307d) * dspace-api: fix misaligned comment (cherry picked from commit 4fba787) * oai_openaire.xsl : change resourceTypeGeneral for thesis Thesis are "Literature" resource type (resourceTypeGeneral), not "other research product" ref: openaire/guidelines-literature-repositories#43 (comment) and https://api.openaire.eu/vocabularies/dnet:result_typologies/publication (cherry picked from commit 669ff34) * Bump org.eclipse.jetty:jetty-http Bumps [org.eclipse.jetty:jetty-http](https://github.com/eclipse/jetty.project) from 9.4.52.v20230823 to 9.4.53.v20231009. - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.52.v20230823...jetty-9.4.53.v20231009) --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-http dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Bump org.json:json from 20230227 to 20231013 in /dspace-api Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 11a08f1) * Reading localized license file. * Reading localized license file. * Applying commit 6108c98 * quote Pattern for thumbnail resolution constructed from bitstream filename (cherry picked from commit a124807) * check null value of bitstream name before quoting name for regex (cherry picked from commit a9bcc0c) * extract bitstream thumbnail name pattern into own function (cherry picked from commit c5466c2) * Make workflow curation tasks actually work. When curation runs, there was no "current user" and no claimed task, so the code broke when trying to find people to notify about curation failures. (cherry picked from commit a76af35) * Community request: fake EPerson from configuration. (cherry picked from commit bb9e88d) * Correct some documentation. (cherry picked from commit be22790) * Handle missing role. (cherry picked from commit 2e62fa3) * Fix "Site cannot be indexed" error by ignoring ADD/REMOVE events on Site object (cherry picked from commit ef7f02f) * Add a null check when assigning ldap groups Prevent NullReferenceException by checking if the group list is null Fixes DSpace#8920 (cherry picked from commit bb6498e) * 9043 use Templates for compiled XSLT instead of Transformer - use Templates are thread-safe and NOT Transformer (cherry picked from commit 1160341) * Update to newly released XOAI 3.4.0 (cherry picked from commit 160ebbd) * add test and fix (cherry picked from commit 48b0b71) * unset primary bitstream on bitstream service (cherry picked from commit 47ca74b) * adding sql expression to fix deleted primary bitstreams from bundle (cherry picked from commit 8a531ad) * add bundle remove authorization (cherry picked from commit 3255e07) * adding missing bundle REMOVE authorization (cherry picked from commit 4a05600) * add missing head style check (cherry picked from commit caba4bb) * fix style errors (cherry picked from commit 74605f1) * new testDeleteBitstreamAndUnsetPrimaryBitstreamID test for primary bitstream verification (cherry picked from commit e6d108a) * new testDeleteBitstreamAndUnsetPrimaryBitstreamID test for primary bitstream verification (cherry picked from commit ad0d22a) * new testDeleteBitstreamAndUnsetPrimaryBitstreamID remove unnecessary stubs (cherry picked from commit a3e506c) * make comments more clear to understand (cherry picked from commit c0bbd9d) * typo (cherry picked from commit 74cce86) * Add basic pagination to /groups/[uuid]/epersons endpoint (cherry picked from commit 74c7235) * Bug fix. Only use pageSize and offset if >0 (cherry picked from commit 15de2d0) * Add missing pagination test for /groups/[uuid]/epersons (cherry picked from commit 457dd9a) * Add pagination to /groups/[uuid]/subgroups endpoint, along with tests (cherry picked from commit e7c4b9e) * Add basic unit test for new EpersonService methods (cherry picked from commit c000e54) * Minor unit test fix. Use isEqualCollection to compare list with Hibernate results (cherry picked from commit cdb68a6) * Add countAllMembers() with tests. Update tests to use try/catch (cherry picked from commit 58a15b7) * Replace several usages of allMembers() with count methods to avoid performance issues (cherry picked from commit 2c9165a) * Fix bug in logic for determining whether a workflow group will be left empty. Need to check *both* EPerson and subgroup counts. (cherry picked from commit 9832259) * Use join instead of subquery as join seems slightly faster. (cherry picked from commit 9c0bf08) * Address feedback. Initialize HashSet sizes to avoid resizing. Correct comment about indeterminante ordering. (cherry picked from commit f011a5a) * Allow users with write permission to view hidden metadata (cherry picked from commit 65a17d4) * Test modification: allow users with write rights to see hidden metadata (cherry picked from commit df7f6e9) * Add test to check that user with read rights can see hidden metadata (cherry picked from commit 03496c3) * Verify optional message is not missing or a literal "null" value (cherry picked from commit 534ee3a) * Change the database mode to READ_ONLY during the indexing by discovery consumer (IndexEventConsumer) (cherry picked from commit 94822b5) * Add functions to do a manual flush of the db session and call flush before change to READ_ONLY mode to be sure we index the current object (cherry picked from commit c33d3fa) * Flush database changes after switching to READONLY mode (cherry picked from commit 00a6531) * Add test to check retrieving of policies after changing mode to READ_ONLY (cherry picked from commit d19a959) * Change class name to ContextIT and correct a test (cherry picked from commit a556799) * dspace/config: update spider agent list Update list of spider user agents from the COUNTER-Robots project. See: https://github.com/atmire/COUNTER-Robots (cherry picked from commit 7566a79) * removed options to ping search engines when generating sitemaps (cherry picked from commit f8f8806) * XmlWorkflowCuratorServiceImpl: add check to queue task if configured; Curation: remove obsolete code preventing curation running on workflow tasks as DSpace#3157 is now implemented * Return both user and operational LDAP attributes Explicitly request both user and operation attributes for LDAP group search as the default searching does not include operational attributes. This is required to fetch the memberOf attribute when checking LDAP group membership. Fixes DSpace#9151 (cherry picked from commit 56b7cbf) * [DURACOM-200] improvement of checker script (cherry picked from commit 5a7c795) * 108055: isClosed method should use xml configuration (cherry picked from commit d800d80) * [DURACOM-192] Authentication Method related special groups are put in claim set even if a different authentication method is used (cherry picked from commit 6504d74) * [DURACOM-192] Added test (cherry picked from commit fa39251) * 107891: Cache administrator group (cherry picked from commit 1e82ca7) * DURACOM-199 improved test to show bug related to restricted content (cherry picked from commit dac4df9) * DURACOM-199 fix sitemap generator for restricted content and improve performance (cherry picked from commit 6d9ca38) * [Port dspace-7_x] Event consumer for submission config reloading when a collection changes (DSpace#9196) * initialization with refactoring (cherry picked from commit e93dc1c) * also consider SubmissionConfigReaderException (cherry picked from commit 8a04b87) * rename consumer file (cherry picked from commit f6c92a4) * init submission service factory (cherry picked from commit fcc5239) * set submissionconfig config settings by default (cherry picked from commit e343d51) * renaming SubmissionConfigReaderService (cherry picked from commit 9ea7c32) * support for SubmissionConfigService (cherry picked from commit 61389fb) * fixing style errors and renaming submissionConfigService (cherry picked from commit 5f49491) * fixing style errors and unused imports (cherry picked from commit 31d9251) * set default submission event configs (cherry picked from commit 578198c) * adding force indexing action to Consumer (cherry picked from commit b912364) * stylecheck fixes (cherry picked from commit 89e89c3) * undo event.dispatcher.noindex.consumers (cherry picked from commit ae9dc5f) --------- Co-authored-by: Paulo Graça <paulo1978@gmail.com> * Add isNotMemberOf for groups, including unit and integration tests (cherry picked from commit 9d271b2) * Implement searchNonMembers for EPersonService. Add tests to prove it works (and tests for search()). Requires minor bug fix to AbstractHibernateDSODAO to allow for additional OR/AND clauses to be appended. (cherry picked from commit f186dcf) * Add /epersons/search/isNotMemberOf endpoint to REST API along with integration tests (cherry picked from commit 5208a35) * Bug fix to EPersonDAOImpl. Correctly determine if excluded group needs to be preceded by AND or WHERE (cherry picked from commit e5e0eaa) * Updated IIIF Controller IT to text bitstream and bundle exclusions (cherry picked from commit e92b4b7) * Simplified the process of fixing the tests after adding new sidebar facets/search filters and sort options to discover.xml (cherry picked from commit b40ad0d) * 107671: Expose the handle.canonical.prefix to the frontend (cherry picked from commit 6d86e65) * Remove line breaks from default.license because they are being rendered in the frontend (cherry picked from commit 56aae34) * [Port dspace-7_x] subscription email: do not send email if nothing has changed (DSpace#9204) * improved subscriptions email template (cherry picked from commit 6e7b327) * do not send emails without content (cherry picked from commit 926b242) * fixed coding style violations (cherry picked from commit fdacec0) * removed unnecessary isEmpty check as suggested by reviewer (cherry picked from commit 30a837f) * moved null check on indexableObjects in generateBodyMail (cherry picked from commit b43c340) * fixed unhandled IOException (cherry picked from commit 9b3f7b6) * fixed typo in bodyCommunities (cherry picked from commit ac3d02e) * do not use != to compare strings (cherry picked from commit e460183) * fixed improper handling of empty list (cherry picked from commit ac72aae) --------- Co-authored-by: Sascha Szott <szott@gmx.de> * [maven-release-plugin] prepare release dspace-7.6.1 * Fixed checkstyle issues * Fixed compilation errors * Removed redundant service definitions in the `core-factory-services.xml` because unit tests was failing * Removed redundant bean in the `discovery.xml` * Removed redundant `latestVersion` from `schema.xml` * Fixed wrong resolved conflicts - the app cannot start running * Used ClarinVersionedHandleIdentifierProvider instead of Vanilla one in the `identifier-service.xml` * Fixed tests - the user has an authorization to remove bundle * Fixed failing test in the `MetadataExportSearchIT` it was trying to test dateIssued filter, but the CLARIN DSpace doesn't use that. * controlled.authority.dc.relation is changed in the configuration by CLARIN so the test VersioningWithRelationshipsIT is failing because of that. * Fixed wrong license validation class * Removed test which was accidentaly added durign resolving conflicts * The ACL tag restricted loading of some input field which was missing in the assert * The test cannot convert `Oct` from the xml to normal number because of Slovak default locale which doesn't know what `Oct` means in the date. I set up EN locale for the current test * Added clarin set up of search Facets into integration tests - because src/test/java/org/dspace/app/rest/DiscoveryScopeBasedRestControllerIT.java was failing * Added method `areSpecialGroupsApplicable` into ClarinShibAuthentication because after shib authentication the user wasn't assinged into special group because of some dspace new feature * Change DEFAULT_AMOUNT_FORMATS in the BitstreamFormatRestRepositoryIT.java because vanila has added a new format. * Ignored still failing RegistrationRestRepositoryIT test - it is ignored also in the 7.5 version * fix: Failure of org.dspace.app.rest.SitemapRestControllerIT when running locally * Ignore pubmedImportMetadataGetRecordsTest or allow ssl * Let the pubmedImportMetadataGetRecordsTests ignored * Fixed CurationIT - it failed on the Stream because Stream has null param. Null param was because of null handle on the Site object - the site handle was removed in the `ClarinHandleImportControllerIT.java#createHandleWithoutDSpaceObjectTest`. * Do not delete site handle in the HandleRestRepositoryIT * Updated scripts for fast building 7.6.1 * Moved flyway script for updating checksum_results into separate file * Added missing headers --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Sean Kalynuk <Sean.Kalynuk@umanitoba.ca> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Martin Walk <martin.walk@tu-berlin.de> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: David P. Steelman <dsteelma@umd.edu> Co-authored-by: Christian Bethge <54576195+ChrisBethgster@users.noreply.github.com> Co-authored-by: max.nuding <max.nuding@uni-konstanz.de> Co-authored-by: Max Nuding <max.nuding@icloud.com> Co-authored-by: Mark H. Wood <mwood@iu.edu> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Hrafn Malmquist <hrafn.malmquist@gmail.com> Co-authored-by: aroman-arvo <aroman@arvo.es> Co-authored-by: Christian Bethge <christian.bethge@bibliothek.uni-halle.de> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Mark Cooper <mark.c.cooper@outlook.com> Co-authored-by: nwoodward <woodward.nicholas@gmail.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Marie-Hélène Vézina <mhvezina@users.noreply.github.com> Co-authored-by: damian <damian.jozefowski@pcgacademia.pl> Co-authored-by: Gantner, Florian Klaus <florian.gantner@uni-bamberg.de> Co-authored-by: wwuck <wirelessduck@gmail.com> Co-authored-by: Paulo Graça <paulo1978@gmail.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: mohamed eskander <mohamed.eskander@4science.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: Luca Giamminonni <luca.giamminonni@4science.it> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: DSpace Bot <68393067+dspace-bot@users.noreply.github.com> Co-authored-by: Michael Spalti <mspalti@gmail.com> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Shankeerthan Kasilingam <shankeerthan1995@gmail.com> * The cas.init() method is called in the VocabularyRestRepositoryIT#setup() method * Update docker.yml (DSpace#502) dspace-dependencies job was missing * Update docker.yml (DSpace#503) Fixed dspace-dependencies error * [DSC-963] Fixed test configuration * Update docker.yml (DSpace#504) * Empty commit - run actions --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: Adán Román Ruiz <aroman@arvo.es> Co-authored-by: Ondřej Košarko <ko_ok@centrum.cz> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Luca Giamminonni <luca.giamminonni@4science.it> Co-authored-by: Sean Kalynuk <Sean.Kalynuk@umanitoba.ca> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Martin Walk <martin.walk@tu-berlin.de> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: David P. Steelman <dsteelma@umd.edu> Co-authored-by: Christian Bethge <54576195+ChrisBethgster@users.noreply.github.com> Co-authored-by: max.nuding <max.nuding@uni-konstanz.de> Co-authored-by: Max Nuding <max.nuding@icloud.com> Co-authored-by: Mark H. Wood <mwood@iu.edu> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Hrafn Malmquist <hrafn.malmquist@gmail.com> Co-authored-by: Christian Bethge <christian.bethge@bibliothek.uni-halle.de> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Mark Cooper <mark.c.cooper@outlook.com> Co-authored-by: nwoodward <woodward.nicholas@gmail.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Marie-Hélène Vézina <mhvezina@users.noreply.github.com> Co-authored-by: damian <damian.jozefowski@pcgacademia.pl> Co-authored-by: Gantner, Florian Klaus <florian.gantner@uni-bamberg.de> Co-authored-by: wwuck <wirelessduck@gmail.com> Co-authored-by: Paulo Graça <paulo1978@gmail.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: mohamed eskander <mohamed.eskander@4science.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: DSpace Bot <68393067+dspace-bot@users.noreply.github.com> Co-authored-by: Michael Spalti <mspalti@gmail.com> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Shankeerthan Kasilingam <shankeerthan1995@gmail.com> Co-authored-by: Jozef Misutka <332350+vidiecan@users.noreply.github.com>
kosarko
added a commit
to kosarko/DSpace
that referenced
this pull request
Mar 28, 2024
* ufal/downloading-restricted-bitstreams-not-working-properly (DSpace#457) * The admin could download restricted bitstreams. * The user cannot download bitstream if he/she is not signed in. * Cannot obtain context with user. * The user is already fetched from the context. * Added docs. * Do not use endpoint for downloading the single file because it already exists - remove it. * Fixed AuthorizationRestControllerIT tests. * ufal/be-cannot-download-and-preview-files-after-migration (DSpace#454) * Find bitstream format using mimetype not ID. * Updated tests according to fix. * ufal/update-canonical-prefix-to-hdl (DSpace#460) * Updated `handle.canonical.prefix` to hdl handle. * Integration test cannot have changed handle.canonical.prefix. * ufal/be-user-registration-missing (DSpace#463) * The user registration is added when the eperson is created by the ui. * try using newer checkout, same as upstream, since error is with git --------- Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * ufal/be-license-download-statistics (DSpace#462) * Add logging of downloading restricted bitstreams. * Log downloading of every bitstream not only restricted ones. * Added docs * Refactored logging. * ufal/be-shibboleth-headers-encoding (DSpace#464) * givenname and last name values are converted to UTF-8 encoding * Delete eperson in tests * using our dspace-dependencies because of dataquest-dev#466 * ufal/be-fix-email-parameters Fixed emails sending - added arguments and cfg properties that are sent in the email. (DSpace#470) * ufal/be-provenance-subbmitter-missing (DSpace#469) * DSpace#8585 Add submitter information to provenance metadata * Cherry picked fix from vanilla and added test to check if the Item provenance metadata is added --------- Co-authored-by: Adán Román Ruiz <aroman@arvo.es> * ufal/be-get-user-ip-address (DSpace#468) * Created endpoint for fetching IP address with tests. * Made the code more understable * ufal/publisher-ok-fix (DSpace#473) * fixes ufal#1096 (DSpace#471) * Added publisher filter in the integration test check --------- Co-authored-by: Ondřej Košarko <ko_ok@centrum.cz> * ufal/zip-preview-configurable (DSpace#475) * Made previewing of the file configurable. * The default value of the previewing the file must be true in the integration tests. * ufal/fe-oversized-file-upload-message Exposed max file limit for upload from the cfg. (DSpace#477) * ufal/be-email-restricted-download * Fixed comments in the clarin emails (DSpace#484) * ufal/be-not-show-shib-welcome-page (DSpace#485) * Added cfg property to enable/disable showing of the page with attributes passed from the idp. * ufal/be-s3-customization (DSpace#481) * The bitstream data are stored in to local store after uploading to S3 * The bitstream is removed from the S3 and local assetstore * Store number is specific if all storages are synchronized. * Return store number in the BitstreamRest object * Find out which store is used - it could be synchronized stores number. * Constant is moved to the Bitstream class * Synchronization of storages is not allowed by default - set up it in the test environment. * Added docs * Removed constant from the Bitstream class - it wasn't consistent * Overriden BitstreamStorageServiceImpl by custom SyncBitstreamStorageServiceImpl * Removed ClarinS3BitStoreService.java to SyncS3BitStoreService * Added doc and refactoring. * ufal/be-s3-checker-sync (DSpace#486) * Fixed UserCheck - There was created a wrong select * Fixed ChecksumCheck - the session was closed but there were some requests do the database then * internal/load-version-from-file (DSpace#488) * Load version from the specific file and show content in the root endpoint. * Fixed checkstyle issue * DO not log anything if the VERSION file does not exist. Added VERSION file path into cfg property. * Append every line into final String. * ufal/be-s3-checksum-fix (DSpace#487) * Cherry picked fix S3 optimalization fixes from Vanilla * Cherry picked adding of pagination on cleanup * Updated Sync services according to S3 optimization fix * The checksum value is compared between S3 and local assetstore and the new result is inserted to the database. * Added docs and refactoring * The checksum values are exposed by REST API * Fixed failing tests --------- Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Luca Giamminonni <luca.giamminonni@4science.it> * internal/versioning (DSpace#491) * add version to docker * Allow shell because it is using double quotes in the command string. * removed cat and ls commands --------- Co-authored-by: MajoBerger <marian.berger@dataquest.sk> * ufal/comment-ever-failing-test * Commented still failing tests (DSpace#490) * internal/verion-update-path (DSpace#492) * Updated `build.version.file.path` because the server cannot find `VERSION_D.txt` file * Added VERSION_D.txt info `.gitignore` * User ${dspace.dir} instead of absolute path * internal/be-upgrade-clarin-dspace-7.6 (DSpace#497) * Split docker image builds into separate jobs to allow them to run in parallel. * Ensure 'main' code is tagged as 'latest' in DockerHub * Fixes DSpace#8558 - set Solr UTC timezone Set the timezone of the Solr date formatter to UTC * remove obsolete code fragments * Add action to automatically create a port PR when specified (cherry picked from commit f6a898c) * Run PR Port action as 'dspace-bot' to allow new PRs to trigger CI checks * Minor update to label_merge_conflicts to ignore any errors (seem random at this time) * Fix typo. Config must be a valid regex (cherry picked from commit 7995289) * Bump h2 from 2.1.214 to 2.2.220 Bumps [h2](https://github.com/h2database/h2database) from 2.1.214 to 2.2.220. - [Release notes](https://github.com/h2database/h2database/releases) - [Commits](h2database/h2database@version-2.1.214...version-2.2.220) --- updated-dependencies: - dependency-name: com.h2database:h2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update FullTextContentStreams.java Fix NPE if bitstream is null * Update FullTextContentStreams.java Add additional NPE checks * Update ItemUtils.java Prevent npe if bitstream is null * dspace.cfg: remove old webui.itemlist properties These properties are no longer used in DSpace 7: webui.itemlist.widths webui.itemlist.*.widths webui.itemlist.tablewidth (cherry picked from commit 16c46c4) * dspace.cfg: remove old webui.browse.thumbnail.show property The webui.browse.thumbnail.show property is no longer used as of DSpace 7. Also remove subsequent references to adding thumbnails to item view columns since these are from legacy DSpace. (cherry picked from commit 213a546) * dspace.cfg: remove old webui.itemlist.browse.* property The webui.itemlist.browse.* properties are no longer used in DSpace 7. (cherry picked from commit 35f72bc) * Fix DSpace#8963: Remove deletion constraint from Groomer * Enable entity type to submission form mapping by default (cherry picked from commit b71eee8) * [DURACOM-179] replaced 'null' value with exception actual value in sendErrorResponse method calls having 'null' (cherry picked from commit aa35a47) * DS-8935. webui.browse.link CrossLinks - Fix for multiple exact matches Fixes DSpace#8935 when multiple exact match "webui.browse.link" configuration entries are present that point to different indexes. Modified the code to return the index associated with the given metadata (which is used as the key in the hash map), instead of the key from the keySet (which may not actually be the metadata value being searched for). DSpace#8935 (cherry picked from commit b846c53) * DSpace#9006 fix referenced configuration file (cherry picked from commit 29a88d7) * DSpace#9006 fix referenced configuration file (Test) (cherry picked from commit 309b0b3) * Fix DSpace#8933: Only add the base statistic core if it hasn't already been added * Remove duplicate code * On failure log the name of the assetstore file and trace causes of exception. (cherry picked from commit 22974e9) * Report Throwable's type too. (cherry picked from commit d6b612f) * More description on OutOfMemoryError too. (cherry picked from commit bbe5df3) * Remove useless log.info (cherry picked from commit 1f3ad99) * 103837: Refactor GA config to list bundles * README.md: Fix typo (cherry picked from commit ca8abdd) * Bump up versions of buildnumber-maven-plugin & build-helper-maven-plugin. add configuration for SCM failure (cherry picked from commit 78ea9e8) * 3331 - remove the --optimize feature of 'dspace stats-util' (cherry picked from commit 08c6509) * fix MissingOptionException on help (cherry picked from commit 8ae5ffb) * fix stylecheck (cherry picked from commit b1377ca) * ingore unrecognized arguments on help (cherry picked from commit 82c9b6f) * add DSpaceSkipUnknownArgumentsParser as parser to ignore/skip unknown arguments in cli by help, fix not necessary ParseException in help (cherry picked from commit 86285d7) * remove not necessary else (cherry picked from commit 064e2ca) * Enable new skip merge commit feature * dspace-api: remove unnecessary trailing whitespace * 103818 ItemServiceImpl#inheritCollectionDefaultPolicies now clears item READ policies if new parent collection has a default READ policy * 103818 Add boolean parameter to ItemServiceImpl#inheritCollectionDefaultPolicies to decide whether to override item read policies * 103818 Add boolean parameters to ItemServiceImpl methodds to decide whether to override read policies * 103818 Extend ItemServiceTest#testMoveItemToCollectionWithMoreRestrictiveReadPolicy * 104878 Fix error in ItemServiceTest related to inheriting collection policies upon item move * 104878 Adjust ItemServiceTest to expect correct behavior of bundles when item is migrated * Fix failing IT in BulkAccessControlIT * 103837: Fix isContentBitstream() in GoogleAsyncEventListener * Rename test suites that are really integration testing. (cherry picked from commit f66ca33) * Bump org.eclipse.jetty:jetty-xml Bumps [org.eclipse.jetty:jetty-xml](https://github.com/eclipse/jetty.project) from 9.4.51.v20230217 to 9.4.52.v20230823. - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.51.v20230217...jetty-9.4.52.v20230823) --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-xml dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 2bcc0b3) * Add note that rebooting Tomcat required * Add websvc.opensearch.autolink and websvc.opensearch.shortname to exposed REST configuration properties (cherry picked from commit 80b35c9) * Add a "container friendly" log4j2 cfg and output compose dspace log to console (cherry picked from commit 9eefd56) * Fix ClassCastException (Collection cannot be cast to Item) in Handle identifier classes (cherry picked from commit 1271374) * Fix checkstyle. Correct grammar of comment while doing so. (cherry picked from commit ffa2683) * Avoid double slashes in sitemap paths. (cherry picked from commit eae4463) * Remove 'cross join' from count query. Updates "countHandlesByPrefix" to use a query similar to existing "findByPrefix" (cherry picked from commit 14223bd) * fix logical bug when checking if field is controlled authority * remove optimize option from oai import * added authorization check for license bitstream in OAI import * OAI: add support to extract embargo from bitstreams and expose it in OAI metadata (cherry picked from commit db81d75) * ItemUtils.java: added method doc (cherry picked from commit 51e60fb) * ItemUtils.java: improved method to account for multiple embargo policies and select the longest embargo (cherry picked from commit 538be7f) * Refactored access-status to include embargo date based on the DefaultAccessStatusHelper logic (look at primary or first bitstream) (cherry picked from commit 895926f) * Remove unused imports (cherry picked from commit 4bd2cfd) * Fix style issues (cherry picked from commit 724a4ff) * Fix style issues (cherry picked from commit 6e2c8a4) * Add null check (cherry picked from commit 0de4c39) * ItemUtils.java: refactored addEmbargoField (cherry picked from commit 291afa7) * uketd_dc.xsl: also expose access-status if embargo or restricted (cherry picked from commit 4b40872) * DefaultAccessStatusHelper: fix logic to take shortest embargo (cherry picked from commit d17ef09) * Remove currently unused customisation of ItemUtils (cherry picked from commit 490a982) * DefaultAccessStatusHelper: getEmbargoFromItem return null embargo if status than embargo (cherry picked from commit e05e73a) * Additional Item class cast fixes in handle providers DSOs were not properly checked if they were instanceof Item before attempting the cast in HandleIdentifierProvider and VersionedHandleIdentifierProviderWithCanonicalHandles * Remove Oracle script that accidentally made it in via DSpace#8800 (cherry picked from commit 5e04edf) * 8968 - request-a-copy email: non ASCII characters are encoded as HTML character entity references (cherry picked from commit db36d5e) * unused import (cherry picked from commit bf6e042) * 8968 - added custom StringEscapper (cherry picked from commit 103c8ee) * checkstyle (cherry picked from commit 2c2b3b1) * 8968 - implementated using HtmlUtils scaping (cherry picked from commit 090beed) * checkstiye (cherry picked from commit d12fbe2) * Define _version_ * DSpace#8585 Add submitter information to provenance metadata (cherry picked from commit c15ac0e) * 8585 - added provenance to metadata-import and itemImport (cherry picked from commit ea6307d) * dspace-api: fix misaligned comment (cherry picked from commit 4fba787) * oai_openaire.xsl : change resourceTypeGeneral for thesis Thesis are "Literature" resource type (resourceTypeGeneral), not "other research product" ref: openaire/guidelines-literature-repositories#43 (comment) and https://api.openaire.eu/vocabularies/dnet:result_typologies/publication (cherry picked from commit 669ff34) * Bump org.eclipse.jetty:jetty-http Bumps [org.eclipse.jetty:jetty-http](https://github.com/eclipse/jetty.project) from 9.4.52.v20230823 to 9.4.53.v20231009. - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.52.v20230823...jetty-9.4.53.v20231009) --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-http dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Bump org.json:json from 20230227 to 20231013 in /dspace-api Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 11a08f1) * Reading localized license file. * Reading localized license file. * Applying commit 6108c98 * quote Pattern for thumbnail resolution constructed from bitstream filename (cherry picked from commit a124807) * check null value of bitstream name before quoting name for regex (cherry picked from commit a9bcc0c) * extract bitstream thumbnail name pattern into own function (cherry picked from commit c5466c2) * Make workflow curation tasks actually work. When curation runs, there was no "current user" and no claimed task, so the code broke when trying to find people to notify about curation failures. (cherry picked from commit a76af35) * Community request: fake EPerson from configuration. (cherry picked from commit bb9e88d) * Correct some documentation. (cherry picked from commit be22790) * Handle missing role. (cherry picked from commit 2e62fa3) * Fix "Site cannot be indexed" error by ignoring ADD/REMOVE events on Site object (cherry picked from commit ef7f02f) * Add a null check when assigning ldap groups Prevent NullReferenceException by checking if the group list is null Fixes DSpace#8920 (cherry picked from commit bb6498e) * 9043 use Templates for compiled XSLT instead of Transformer - use Templates are thread-safe and NOT Transformer (cherry picked from commit 1160341) * Update to newly released XOAI 3.4.0 (cherry picked from commit 160ebbd) * add test and fix (cherry picked from commit 48b0b71) * unset primary bitstream on bitstream service (cherry picked from commit 47ca74b) * adding sql expression to fix deleted primary bitstreams from bundle (cherry picked from commit 8a531ad) * add bundle remove authorization (cherry picked from commit 3255e07) * adding missing bundle REMOVE authorization (cherry picked from commit 4a05600) * add missing head style check (cherry picked from commit caba4bb) * fix style errors (cherry picked from commit 74605f1) * new testDeleteBitstreamAndUnsetPrimaryBitstreamID test for primary bitstream verification (cherry picked from commit e6d108a) * new testDeleteBitstreamAndUnsetPrimaryBitstreamID test for primary bitstream verification (cherry picked from commit ad0d22a) * new testDeleteBitstreamAndUnsetPrimaryBitstreamID remove unnecessary stubs (cherry picked from commit a3e506c) * make comments more clear to understand (cherry picked from commit c0bbd9d) * typo (cherry picked from commit 74cce86) * Add basic pagination to /groups/[uuid]/epersons endpoint (cherry picked from commit 74c7235) * Bug fix. Only use pageSize and offset if >0 (cherry picked from commit 15de2d0) * Add missing pagination test for /groups/[uuid]/epersons (cherry picked from commit 457dd9a) * Add pagination to /groups/[uuid]/subgroups endpoint, along with tests (cherry picked from commit e7c4b9e) * Add basic unit test for new EpersonService methods (cherry picked from commit c000e54) * Minor unit test fix. Use isEqualCollection to compare list with Hibernate results (cherry picked from commit cdb68a6) * Add countAllMembers() with tests. Update tests to use try/catch (cherry picked from commit 58a15b7) * Replace several usages of allMembers() with count methods to avoid performance issues (cherry picked from commit 2c9165a) * Fix bug in logic for determining whether a workflow group will be left empty. Need to check *both* EPerson and subgroup counts. (cherry picked from commit 9832259) * Use join instead of subquery as join seems slightly faster. (cherry picked from commit 9c0bf08) * Address feedback. Initialize HashSet sizes to avoid resizing. Correct comment about indeterminante ordering. (cherry picked from commit f011a5a) * Allow users with write permission to view hidden metadata (cherry picked from commit 65a17d4) * Test modification: allow users with write rights to see hidden metadata (cherry picked from commit df7f6e9) * Add test to check that user with read rights can see hidden metadata (cherry picked from commit 03496c3) * Verify optional message is not missing or a literal "null" value (cherry picked from commit 534ee3a) * Change the database mode to READ_ONLY during the indexing by discovery consumer (IndexEventConsumer) (cherry picked from commit 94822b5) * Add functions to do a manual flush of the db session and call flush before change to READ_ONLY mode to be sure we index the current object (cherry picked from commit c33d3fa) * Flush database changes after switching to READONLY mode (cherry picked from commit 00a6531) * Add test to check retrieving of policies after changing mode to READ_ONLY (cherry picked from commit d19a959) * Change class name to ContextIT and correct a test (cherry picked from commit a556799) * dspace/config: update spider agent list Update list of spider user agents from the COUNTER-Robots project. See: https://github.com/atmire/COUNTER-Robots (cherry picked from commit 7566a79) * removed options to ping search engines when generating sitemaps (cherry picked from commit f8f8806) * XmlWorkflowCuratorServiceImpl: add check to queue task if configured; Curation: remove obsolete code preventing curation running on workflow tasks as DSpace#3157 is now implemented * Return both user and operational LDAP attributes Explicitly request both user and operation attributes for LDAP group search as the default searching does not include operational attributes. This is required to fetch the memberOf attribute when checking LDAP group membership. Fixes DSpace#9151 (cherry picked from commit 56b7cbf) * [DURACOM-200] improvement of checker script (cherry picked from commit 5a7c795) * 108055: isClosed method should use xml configuration (cherry picked from commit d800d80) * [DURACOM-192] Authentication Method related special groups are put in claim set even if a different authentication method is used (cherry picked from commit 6504d74) * [DURACOM-192] Added test (cherry picked from commit fa39251) * 107891: Cache administrator group (cherry picked from commit 1e82ca7) * DURACOM-199 improved test to show bug related to restricted content (cherry picked from commit dac4df9) * DURACOM-199 fix sitemap generator for restricted content and improve performance (cherry picked from commit 6d9ca38) * [Port dspace-7_x] Event consumer for submission config reloading when a collection changes (DSpace#9196) * initialization with refactoring (cherry picked from commit e93dc1c) * also consider SubmissionConfigReaderException (cherry picked from commit 8a04b87) * rename consumer file (cherry picked from commit f6c92a4) * init submission service factory (cherry picked from commit fcc5239) * set submissionconfig config settings by default (cherry picked from commit e343d51) * renaming SubmissionConfigReaderService (cherry picked from commit 9ea7c32) * support for SubmissionConfigService (cherry picked from commit 61389fb) * fixing style errors and renaming submissionConfigService (cherry picked from commit 5f49491) * fixing style errors and unused imports (cherry picked from commit 31d9251) * set default submission event configs (cherry picked from commit 578198c) * adding force indexing action to Consumer (cherry picked from commit b912364) * stylecheck fixes (cherry picked from commit 89e89c3) * undo event.dispatcher.noindex.consumers (cherry picked from commit ae9dc5f) --------- Co-authored-by: Paulo Graça <paulo1978@gmail.com> * Add isNotMemberOf for groups, including unit and integration tests (cherry picked from commit 9d271b2) * Implement searchNonMembers for EPersonService. Add tests to prove it works (and tests for search()). Requires minor bug fix to AbstractHibernateDSODAO to allow for additional OR/AND clauses to be appended. (cherry picked from commit f186dcf) * Add /epersons/search/isNotMemberOf endpoint to REST API along with integration tests (cherry picked from commit 5208a35) * Bug fix to EPersonDAOImpl. Correctly determine if excluded group needs to be preceded by AND or WHERE (cherry picked from commit e5e0eaa) * Updated IIIF Controller IT to text bitstream and bundle exclusions (cherry picked from commit e92b4b7) * Simplified the process of fixing the tests after adding new sidebar facets/search filters and sort options to discover.xml (cherry picked from commit b40ad0d) * 107671: Expose the handle.canonical.prefix to the frontend (cherry picked from commit 6d86e65) * Remove line breaks from default.license because they are being rendered in the frontend (cherry picked from commit 56aae34) * [Port dspace-7_x] subscription email: do not send email if nothing has changed (DSpace#9204) * improved subscriptions email template (cherry picked from commit 6e7b327) * do not send emails without content (cherry picked from commit 926b242) * fixed coding style violations (cherry picked from commit fdacec0) * removed unnecessary isEmpty check as suggested by reviewer (cherry picked from commit 30a837f) * moved null check on indexableObjects in generateBodyMail (cherry picked from commit b43c340) * fixed unhandled IOException (cherry picked from commit 9b3f7b6) * fixed typo in bodyCommunities (cherry picked from commit ac3d02e) * do not use != to compare strings (cherry picked from commit e460183) * fixed improper handling of empty list (cherry picked from commit ac72aae) --------- Co-authored-by: Sascha Szott <szott@gmx.de> * [maven-release-plugin] prepare release dspace-7.6.1 * Fixed checkstyle issues * Fixed compilation errors * Removed redundant service definitions in the `core-factory-services.xml` because unit tests was failing * Removed redundant bean in the `discovery.xml` * Removed redundant `latestVersion` from `schema.xml` * Fixed wrong resolved conflicts - the app cannot start running * Used ClarinVersionedHandleIdentifierProvider instead of Vanilla one in the `identifier-service.xml` * Fixed tests - the user has an authorization to remove bundle * Fixed failing test in the `MetadataExportSearchIT` it was trying to test dateIssued filter, but the CLARIN DSpace doesn't use that. * controlled.authority.dc.relation is changed in the configuration by CLARIN so the test VersioningWithRelationshipsIT is failing because of that. * Fixed wrong license validation class * Removed test which was accidentaly added durign resolving conflicts * The ACL tag restricted loading of some input field which was missing in the assert * The test cannot convert `Oct` from the xml to normal number because of Slovak default locale which doesn't know what `Oct` means in the date. I set up EN locale for the current test * Added clarin set up of search Facets into integration tests - because src/test/java/org/dspace/app/rest/DiscoveryScopeBasedRestControllerIT.java was failing * Added method `areSpecialGroupsApplicable` into ClarinShibAuthentication because after shib authentication the user wasn't assinged into special group because of some dspace new feature * Change DEFAULT_AMOUNT_FORMATS in the BitstreamFormatRestRepositoryIT.java because vanila has added a new format. * Ignored still failing RegistrationRestRepositoryIT test - it is ignored also in the 7.5 version * fix: Failure of org.dspace.app.rest.SitemapRestControllerIT when running locally * Ignore pubmedImportMetadataGetRecordsTest or allow ssl * Let the pubmedImportMetadataGetRecordsTests ignored * Fixed CurationIT - it failed on the Stream because Stream has null param. Null param was because of null handle on the Site object - the site handle was removed in the `ClarinHandleImportControllerIT.java#createHandleWithoutDSpaceObjectTest`. * Do not delete site handle in the HandleRestRepositoryIT * Updated scripts for fast building 7.6.1 * Moved flyway script for updating checksum_results into separate file * Added missing headers --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Sean Kalynuk <Sean.Kalynuk@umanitoba.ca> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Martin Walk <martin.walk@tu-berlin.de> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: David P. Steelman <dsteelma@umd.edu> Co-authored-by: Christian Bethge <54576195+ChrisBethgster@users.noreply.github.com> Co-authored-by: max.nuding <max.nuding@uni-konstanz.de> Co-authored-by: Max Nuding <max.nuding@icloud.com> Co-authored-by: Mark H. Wood <mwood@iu.edu> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Hrafn Malmquist <hrafn.malmquist@gmail.com> Co-authored-by: aroman-arvo <aroman@arvo.es> Co-authored-by: Christian Bethge <christian.bethge@bibliothek.uni-halle.de> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Mark Cooper <mark.c.cooper@outlook.com> Co-authored-by: nwoodward <woodward.nicholas@gmail.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Marie-Hélène Vézina <mhvezina@users.noreply.github.com> Co-authored-by: damian <damian.jozefowski@pcgacademia.pl> Co-authored-by: Gantner, Florian Klaus <florian.gantner@uni-bamberg.de> Co-authored-by: wwuck <wirelessduck@gmail.com> Co-authored-by: Paulo Graça <paulo1978@gmail.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: mohamed eskander <mohamed.eskander@4science.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: Luca Giamminonni <luca.giamminonni@4science.it> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: DSpace Bot <68393067+dspace-bot@users.noreply.github.com> Co-authored-by: Michael Spalti <mspalti@gmail.com> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Shankeerthan Kasilingam <shankeerthan1995@gmail.com> * The cas.init() method is called in the VocabularyRestRepositoryIT#setup() method * Update docker.yml (DSpace#502) dspace-dependencies job was missing * Update docker.yml (DSpace#503) Fixed dspace-dependencies error * Update docker.yml (DSpace#504) * Empty commit - run actions * use checkstyle before commit * remove fix duplicate dependency * remove discofeed related fetching from obsolete discojuice servers (DSpace#508) * remove discofeed related fetching from obsolete discojuice servers * check style, turned off in testing, turned of by default * fix failing test --------- Co-authored-by: jm <jm@maz> * ufal/cannot-upload-big-file (DSpace#533) * Do not compute localChecksum because it takes too long for the big files. The checksum is computed using DigestInputStream object. Copy content into sync local assetstore using buffered copying. * Fixed checkstyle issue * Updated comment about creating required directories * ufal/license-agreement-wrong-behaviour (DSpace#534) * The all transactions are not updated in the user metadata after a new download.. * Return the user metadata depending on user registration, bitstream, mapping and the last translation. * Fixed checkstyle issues * Fixed failing integration tests - do not fetch user metadata for testing by ID where there are more tests which creates the user metadata * internal/discofeed-it (DSpace#535) * Disable SSL check for specific discofeed requests * Fixed checkstyle issues * Do not throw error in private constructor * Fixed failing IT - ssl check wasn't disabled * Ignore integration test which is trying to connect to our private network. * allow running from branch rework-actions for testing * ufal/s3-check-etag (DSpace#537) * Temp commit - upload a file by uploading 50MB parts * Added uploading the file by parts - for every part is computed checksum and compared with UploadPartResult's ETag. This feature could be enabled or disabled by cfg. * Undo S3BitStoreService changes * Fixed checkstyle issues * Prettify the code * Changed cfg property to be better understandable and file size is converted into constant. * ufal/allow-impersonating Allow impersonating by default (DSpace#539) * correct branches for main gh actions * Rework actions (DSpace#540) * run correct actions on correct repos * remove old docker job, separating it to several * reusable build yml from upstream * upstream docker.yml version * first test run * steppify docker.yml action to be able to add more steps * added python version to reusable build * fix incorrect usage of steps in gh action * corect the type in reusable wf * correct condition in python version script * corrected the branch * corrected image dockerhub owner * no linux/arm64 * comment out unused tasks; minor corrections * do not redepoy becuse jm said so * do not use codecov * disable deploy differently * extend possibilities for using version script (DSpace#542) * parametrized output of python version script * RUUUN * correct version placement * correct branches for run of gh action * Fix all mistakes in the /home page (DSpace#543) * Configured browsing by language * Updated tests following the browsing cfg --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: Adán Román Ruiz <aroman@arvo.es> Co-authored-by: Ondřej Košarko <ko_ok@centrum.cz> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Luca Giamminonni <luca.giamminonni@4science.it> Co-authored-by: Sean Kalynuk <Sean.Kalynuk@umanitoba.ca> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Martin Walk <martin.walk@tu-berlin.de> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: David P. Steelman <dsteelma@umd.edu> Co-authored-by: Christian Bethge <54576195+ChrisBethgster@users.noreply.github.com> Co-authored-by: max.nuding <max.nuding@uni-konstanz.de> Co-authored-by: Max Nuding <max.nuding@icloud.com> Co-authored-by: Mark H. Wood <mwood@iu.edu> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Hrafn Malmquist <hrafn.malmquist@gmail.com> Co-authored-by: Christian Bethge <christian.bethge@bibliothek.uni-halle.de> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Mark Cooper <mark.c.cooper@outlook.com> Co-authored-by: nwoodward <woodward.nicholas@gmail.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Marie-Hélène Vézina <mhvezina@users.noreply.github.com> Co-authored-by: damian <damian.jozefowski@pcgacademia.pl> Co-authored-by: Gantner, Florian Klaus <florian.gantner@uni-bamberg.de> Co-authored-by: wwuck <wirelessduck@gmail.com> Co-authored-by: Paulo Graça <paulo1978@gmail.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: mohamed eskander <mohamed.eskander@4science.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: DSpace Bot <68393067+dspace-bot@users.noreply.github.com> Co-authored-by: Michael Spalti <mspalti@gmail.com> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Shankeerthan Kasilingam <shankeerthan1995@gmail.com> Co-authored-by: jm <jm@maz> Co-authored-by: Jozef Misutka <332350+vidiecan@users.noreply.github.com>
kosarko
added a commit
to kosarko/DSpace
that referenced
this pull request
Mar 28, 2024
* ufal/downloading-restricted-bitstreams-not-working-properly (DSpace#457) * The admin could download restricted bitstreams. * The user cannot download bitstream if he/she is not signed in. * Cannot obtain context with user. * The user is already fetched from the context. * Added docs. * Do not use endpoint for downloading the single file because it already exists - remove it. * Fixed AuthorizationRestControllerIT tests. * ufal/be-cannot-download-and-preview-files-after-migration (DSpace#454) * Find bitstream format using mimetype not ID. * Updated tests according to fix. * ufal/update-canonical-prefix-to-hdl (DSpace#460) * Updated `handle.canonical.prefix` to hdl handle. * Integration test cannot have changed handle.canonical.prefix. * ufal/be-user-registration-missing (DSpace#463) * The user registration is added when the eperson is created by the ui. * try using newer checkout, same as upstream, since error is with git --------- Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * ufal/be-license-download-statistics (DSpace#462) * Add logging of downloading restricted bitstreams. * Log downloading of every bitstream not only restricted ones. * Added docs * Refactored logging. * ufal/be-shibboleth-headers-encoding (DSpace#464) * givenname and last name values are converted to UTF-8 encoding * Delete eperson in tests * using our dspace-dependencies because of dataquest-dev#466 * ufal/be-fix-email-parameters Fixed emails sending - added arguments and cfg properties that are sent in the email. (DSpace#470) * ufal/be-provenance-subbmitter-missing (DSpace#469) * DSpace#8585 Add submitter information to provenance metadata * Cherry picked fix from vanilla and added test to check if the Item provenance metadata is added --------- Co-authored-by: Adán Román Ruiz <aroman@arvo.es> * ufal/be-get-user-ip-address (DSpace#468) * Created endpoint for fetching IP address with tests. * Made the code more understable * ufal/publisher-ok-fix (DSpace#473) * fixes ufal#1096 (DSpace#471) * Added publisher filter in the integration test check --------- Co-authored-by: Ondřej Košarko <ko_ok@centrum.cz> * ufal/zip-preview-configurable (DSpace#475) * Made previewing of the file configurable. * The default value of the previewing the file must be true in the integration tests. * ufal/fe-oversized-file-upload-message Exposed max file limit for upload from the cfg. (DSpace#477) * ufal/be-email-restricted-download * Fixed comments in the clarin emails (DSpace#484) * ufal/be-not-show-shib-welcome-page (DSpace#485) * Added cfg property to enable/disable showing of the page with attributes passed from the idp. * ufal/be-s3-customization (DSpace#481) * The bitstream data are stored in to local store after uploading to S3 * The bitstream is removed from the S3 and local assetstore * Store number is specific if all storages are synchronized. * Return store number in the BitstreamRest object * Find out which store is used - it could be synchronized stores number. * Constant is moved to the Bitstream class * Synchronization of storages is not allowed by default - set up it in the test environment. * Added docs * Removed constant from the Bitstream class - it wasn't consistent * Overriden BitstreamStorageServiceImpl by custom SyncBitstreamStorageServiceImpl * Removed ClarinS3BitStoreService.java to SyncS3BitStoreService * Added doc and refactoring. * ufal/be-s3-checker-sync (DSpace#486) * Fixed UserCheck - There was created a wrong select * Fixed ChecksumCheck - the session was closed but there were some requests do the database then * internal/load-version-from-file (DSpace#488) * Load version from the specific file and show content in the root endpoint. * Fixed checkstyle issue * DO not log anything if the VERSION file does not exist. Added VERSION file path into cfg property. * Append every line into final String. * ufal/be-s3-checksum-fix (DSpace#487) * Cherry picked fix S3 optimalization fixes from Vanilla * Cherry picked adding of pagination on cleanup * Updated Sync services according to S3 optimization fix * The checksum value is compared between S3 and local assetstore and the new result is inserted to the database. * Added docs and refactoring * The checksum values are exposed by REST API * Fixed failing tests --------- Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Luca Giamminonni <luca.giamminonni@4science.it> * internal/versioning (DSpace#491) * add version to docker * Allow shell because it is using double quotes in the command string. * removed cat and ls commands --------- Co-authored-by: MajoBerger <marian.berger@dataquest.sk> * ufal/comment-ever-failing-test * Commented still failing tests (DSpace#490) * internal/verion-update-path (DSpace#492) * Updated `build.version.file.path` because the server cannot find `VERSION_D.txt` file * Added VERSION_D.txt info `.gitignore` * User ${dspace.dir} instead of absolute path * internal/be-upgrade-clarin-dspace-7.6 (DSpace#497) * Split docker image builds into separate jobs to allow them to run in parallel. * Ensure 'main' code is tagged as 'latest' in DockerHub * Fixes DSpace#8558 - set Solr UTC timezone Set the timezone of the Solr date formatter to UTC * remove obsolete code fragments * Add action to automatically create a port PR when specified (cherry picked from commit f6a898c) * Run PR Port action as 'dspace-bot' to allow new PRs to trigger CI checks * Minor update to label_merge_conflicts to ignore any errors (seem random at this time) * Fix typo. Config must be a valid regex (cherry picked from commit 7995289) * Bump h2 from 2.1.214 to 2.2.220 Bumps [h2](https://github.com/h2database/h2database) from 2.1.214 to 2.2.220. - [Release notes](https://github.com/h2database/h2database/releases) - [Commits](h2database/h2database@version-2.1.214...version-2.2.220) --- updated-dependencies: - dependency-name: com.h2database:h2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update FullTextContentStreams.java Fix NPE if bitstream is null * Update FullTextContentStreams.java Add additional NPE checks * Update ItemUtils.java Prevent npe if bitstream is null * dspace.cfg: remove old webui.itemlist properties These properties are no longer used in DSpace 7: webui.itemlist.widths webui.itemlist.*.widths webui.itemlist.tablewidth (cherry picked from commit 16c46c4) * dspace.cfg: remove old webui.browse.thumbnail.show property The webui.browse.thumbnail.show property is no longer used as of DSpace 7. Also remove subsequent references to adding thumbnails to item view columns since these are from legacy DSpace. (cherry picked from commit 213a546) * dspace.cfg: remove old webui.itemlist.browse.* property The webui.itemlist.browse.* properties are no longer used in DSpace 7. (cherry picked from commit 35f72bc) * Fix DSpace#8963: Remove deletion constraint from Groomer * Enable entity type to submission form mapping by default (cherry picked from commit b71eee8) * [DURACOM-179] replaced 'null' value with exception actual value in sendErrorResponse method calls having 'null' (cherry picked from commit aa35a47) * DS-8935. webui.browse.link CrossLinks - Fix for multiple exact matches Fixes DSpace#8935 when multiple exact match "webui.browse.link" configuration entries are present that point to different indexes. Modified the code to return the index associated with the given metadata (which is used as the key in the hash map), instead of the key from the keySet (which may not actually be the metadata value being searched for). DSpace#8935 (cherry picked from commit b846c53) * DSpace#9006 fix referenced configuration file (cherry picked from commit 29a88d7) * DSpace#9006 fix referenced configuration file (Test) (cherry picked from commit 309b0b3) * Fix DSpace#8933: Only add the base statistic core if it hasn't already been added * Remove duplicate code * On failure log the name of the assetstore file and trace causes of exception. (cherry picked from commit 22974e9) * Report Throwable's type too. (cherry picked from commit d6b612f) * More description on OutOfMemoryError too. (cherry picked from commit bbe5df3) * Remove useless log.info (cherry picked from commit 1f3ad99) * 103837: Refactor GA config to list bundles * README.md: Fix typo (cherry picked from commit ca8abdd) * Bump up versions of buildnumber-maven-plugin & build-helper-maven-plugin. add configuration for SCM failure (cherry picked from commit 78ea9e8) * 3331 - remove the --optimize feature of 'dspace stats-util' (cherry picked from commit 08c6509) * fix MissingOptionException on help (cherry picked from commit 8ae5ffb) * fix stylecheck (cherry picked from commit b1377ca) * ingore unrecognized arguments on help (cherry picked from commit 82c9b6f) * add DSpaceSkipUnknownArgumentsParser as parser to ignore/skip unknown arguments in cli by help, fix not necessary ParseException in help (cherry picked from commit 86285d7) * remove not necessary else (cherry picked from commit 064e2ca) * Enable new skip merge commit feature * dspace-api: remove unnecessary trailing whitespace * 103818 ItemServiceImpl#inheritCollectionDefaultPolicies now clears item READ policies if new parent collection has a default READ policy * 103818 Add boolean parameter to ItemServiceImpl#inheritCollectionDefaultPolicies to decide whether to override item read policies * 103818 Add boolean parameters to ItemServiceImpl methodds to decide whether to override read policies * 103818 Extend ItemServiceTest#testMoveItemToCollectionWithMoreRestrictiveReadPolicy * 104878 Fix error in ItemServiceTest related to inheriting collection policies upon item move * 104878 Adjust ItemServiceTest to expect correct behavior of bundles when item is migrated * Fix failing IT in BulkAccessControlIT * 103837: Fix isContentBitstream() in GoogleAsyncEventListener * Rename test suites that are really integration testing. (cherry picked from commit f66ca33) * Bump org.eclipse.jetty:jetty-xml Bumps [org.eclipse.jetty:jetty-xml](https://github.com/eclipse/jetty.project) from 9.4.51.v20230217 to 9.4.52.v20230823. - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.51.v20230217...jetty-9.4.52.v20230823) --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-xml dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 2bcc0b3) * Add note that rebooting Tomcat required * Add websvc.opensearch.autolink and websvc.opensearch.shortname to exposed REST configuration properties (cherry picked from commit 80b35c9) * Add a "container friendly" log4j2 cfg and output compose dspace log to console (cherry picked from commit 9eefd56) * Fix ClassCastException (Collection cannot be cast to Item) in Handle identifier classes (cherry picked from commit 1271374) * Fix checkstyle. Correct grammar of comment while doing so. (cherry picked from commit ffa2683) * Avoid double slashes in sitemap paths. (cherry picked from commit eae4463) * Remove 'cross join' from count query. Updates "countHandlesByPrefix" to use a query similar to existing "findByPrefix" (cherry picked from commit 14223bd) * fix logical bug when checking if field is controlled authority * remove optimize option from oai import * added authorization check for license bitstream in OAI import * OAI: add support to extract embargo from bitstreams and expose it in OAI metadata (cherry picked from commit db81d75) * ItemUtils.java: added method doc (cherry picked from commit 51e60fb) * ItemUtils.java: improved method to account for multiple embargo policies and select the longest embargo (cherry picked from commit 538be7f) * Refactored access-status to include embargo date based on the DefaultAccessStatusHelper logic (look at primary or first bitstream) (cherry picked from commit 895926f) * Remove unused imports (cherry picked from commit 4bd2cfd) * Fix style issues (cherry picked from commit 724a4ff) * Fix style issues (cherry picked from commit 6e2c8a4) * Add null check (cherry picked from commit 0de4c39) * ItemUtils.java: refactored addEmbargoField (cherry picked from commit 291afa7) * uketd_dc.xsl: also expose access-status if embargo or restricted (cherry picked from commit 4b40872) * DefaultAccessStatusHelper: fix logic to take shortest embargo (cherry picked from commit d17ef09) * Remove currently unused customisation of ItemUtils (cherry picked from commit 490a982) * DefaultAccessStatusHelper: getEmbargoFromItem return null embargo if status than embargo (cherry picked from commit e05e73a) * Additional Item class cast fixes in handle providers DSOs were not properly checked if they were instanceof Item before attempting the cast in HandleIdentifierProvider and VersionedHandleIdentifierProviderWithCanonicalHandles * Remove Oracle script that accidentally made it in via DSpace#8800 (cherry picked from commit 5e04edf) * 8968 - request-a-copy email: non ASCII characters are encoded as HTML character entity references (cherry picked from commit db36d5e) * unused import (cherry picked from commit bf6e042) * 8968 - added custom StringEscapper (cherry picked from commit 103c8ee) * checkstyle (cherry picked from commit 2c2b3b1) * 8968 - implementated using HtmlUtils scaping (cherry picked from commit 090beed) * checkstiye (cherry picked from commit d12fbe2) * Define _version_ * DSpace#8585 Add submitter information to provenance metadata (cherry picked from commit c15ac0e) * 8585 - added provenance to metadata-import and itemImport (cherry picked from commit ea6307d) * dspace-api: fix misaligned comment (cherry picked from commit 4fba787) * oai_openaire.xsl : change resourceTypeGeneral for thesis Thesis are "Literature" resource type (resourceTypeGeneral), not "other research product" ref: openaire/guidelines-literature-repositories#43 (comment) and https://api.openaire.eu/vocabularies/dnet:result_typologies/publication (cherry picked from commit 669ff34) * Bump org.eclipse.jetty:jetty-http Bumps [org.eclipse.jetty:jetty-http](https://github.com/eclipse/jetty.project) from 9.4.52.v20230823 to 9.4.53.v20231009. - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.52.v20230823...jetty-9.4.53.v20231009) --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-http dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Bump org.json:json from 20230227 to 20231013 in /dspace-api Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 11a08f1) * Reading localized license file. * Reading localized license file. * Applying commit 6108c98 * quote Pattern for thumbnail resolution constructed from bitstream filename (cherry picked from commit a124807) * check null value of bitstream name before quoting name for regex (cherry picked from commit a9bcc0c) * extract bitstream thumbnail name pattern into own function (cherry picked from commit c5466c2) * Make workflow curation tasks actually work. When curation runs, there was no "current user" and no claimed task, so the code broke when trying to find people to notify about curation failures. (cherry picked from commit a76af35) * Community request: fake EPerson from configuration. (cherry picked from commit bb9e88d) * Correct some documentation. (cherry picked from commit be22790) * Handle missing role. (cherry picked from commit 2e62fa3) * Fix "Site cannot be indexed" error by ignoring ADD/REMOVE events on Site object (cherry picked from commit ef7f02f) * Add a null check when assigning ldap groups Prevent NullReferenceException by checking if the group list is null Fixes DSpace#8920 (cherry picked from commit bb6498e) * 9043 use Templates for compiled XSLT instead of Transformer - use Templates are thread-safe and NOT Transformer (cherry picked from commit 1160341) * Update to newly released XOAI 3.4.0 (cherry picked from commit 160ebbd) * add test and fix (cherry picked from commit 48b0b71) * unset primary bitstream on bitstream service (cherry picked from commit 47ca74b) * adding sql expression to fix deleted primary bitstreams from bundle (cherry picked from commit 8a531ad) * add bundle remove authorization (cherry picked from commit 3255e07) * adding missing bundle REMOVE authorization (cherry picked from commit 4a05600) * add missing head style check (cherry picked from commit caba4bb) * fix style errors (cherry picked from commit 74605f1) * new testDeleteBitstreamAndUnsetPrimaryBitstreamID test for primary bitstream verification (cherry picked from commit e6d108a) * new testDeleteBitstreamAndUnsetPrimaryBitstreamID test for primary bitstream verification (cherry picked from commit ad0d22a) * new testDeleteBitstreamAndUnsetPrimaryBitstreamID remove unnecessary stubs (cherry picked from commit a3e506c) * make comments more clear to understand (cherry picked from commit c0bbd9d) * typo (cherry picked from commit 74cce86) * Add basic pagination to /groups/[uuid]/epersons endpoint (cherry picked from commit 74c7235) * Bug fix. Only use pageSize and offset if >0 (cherry picked from commit 15de2d0) * Add missing pagination test for /groups/[uuid]/epersons (cherry picked from commit 457dd9a) * Add pagination to /groups/[uuid]/subgroups endpoint, along with tests (cherry picked from commit e7c4b9e) * Add basic unit test for new EpersonService methods (cherry picked from commit c000e54) * Minor unit test fix. Use isEqualCollection to compare list with Hibernate results (cherry picked from commit cdb68a6) * Add countAllMembers() with tests. Update tests to use try/catch (cherry picked from commit 58a15b7) * Replace several usages of allMembers() with count methods to avoid performance issues (cherry picked from commit 2c9165a) * Fix bug in logic for determining whether a workflow group will be left empty. Need to check *both* EPerson and subgroup counts. (cherry picked from commit 9832259) * Use join instead of subquery as join seems slightly faster. (cherry picked from commit 9c0bf08) * Address feedback. Initialize HashSet sizes to avoid resizing. Correct comment about indeterminante ordering. (cherry picked from commit f011a5a) * Allow users with write permission to view hidden metadata (cherry picked from commit 65a17d4) * Test modification: allow users with write rights to see hidden metadata (cherry picked from commit df7f6e9) * Add test to check that user with read rights can see hidden metadata (cherry picked from commit 03496c3) * Verify optional message is not missing or a literal "null" value (cherry picked from commit 534ee3a) * Change the database mode to READ_ONLY during the indexing by discovery consumer (IndexEventConsumer) (cherry picked from commit 94822b5) * Add functions to do a manual flush of the db session and call flush before change to READ_ONLY mode to be sure we index the current object (cherry picked from commit c33d3fa) * Flush database changes after switching to READONLY mode (cherry picked from commit 00a6531) * Add test to check retrieving of policies after changing mode to READ_ONLY (cherry picked from commit d19a959) * Change class name to ContextIT and correct a test (cherry picked from commit a556799) * dspace/config: update spider agent list Update list of spider user agents from the COUNTER-Robots project. See: https://github.com/atmire/COUNTER-Robots (cherry picked from commit 7566a79) * removed options to ping search engines when generating sitemaps (cherry picked from commit f8f8806) * XmlWorkflowCuratorServiceImpl: add check to queue task if configured; Curation: remove obsolete code preventing curation running on workflow tasks as DSpace#3157 is now implemented * Return both user and operational LDAP attributes Explicitly request both user and operation attributes for LDAP group search as the default searching does not include operational attributes. This is required to fetch the memberOf attribute when checking LDAP group membership. Fixes DSpace#9151 (cherry picked from commit 56b7cbf) * [DURACOM-200] improvement of checker script (cherry picked from commit 5a7c795) * 108055: isClosed method should use xml configuration (cherry picked from commit d800d80) * [DURACOM-192] Authentication Method related special groups are put in claim set even if a different authentication method is used (cherry picked from commit 6504d74) * [DURACOM-192] Added test (cherry picked from commit fa39251) * 107891: Cache administrator group (cherry picked from commit 1e82ca7) * DURACOM-199 improved test to show bug related to restricted content (cherry picked from commit dac4df9) * DURACOM-199 fix sitemap generator for restricted content and improve performance (cherry picked from commit 6d9ca38) * [Port dspace-7_x] Event consumer for submission config reloading when a collection changes (DSpace#9196) * initialization with refactoring (cherry picked from commit e93dc1c) * also consider SubmissionConfigReaderException (cherry picked from commit 8a04b87) * rename consumer file (cherry picked from commit f6c92a4) * init submission service factory (cherry picked from commit fcc5239) * set submissionconfig config settings by default (cherry picked from commit e343d51) * renaming SubmissionConfigReaderService (cherry picked from commit 9ea7c32) * support for SubmissionConfigService (cherry picked from commit 61389fb) * fixing style errors and renaming submissionConfigService (cherry picked from commit 5f49491) * fixing style errors and unused imports (cherry picked from commit 31d9251) * set default submission event configs (cherry picked from commit 578198c) * adding force indexing action to Consumer (cherry picked from commit b912364) * stylecheck fixes (cherry picked from commit 89e89c3) * undo event.dispatcher.noindex.consumers (cherry picked from commit ae9dc5f) --------- Co-authored-by: Paulo Graça <paulo1978@gmail.com> * Add isNotMemberOf for groups, including unit and integration tests (cherry picked from commit 9d271b2) * Implement searchNonMembers for EPersonService. Add tests to prove it works (and tests for search()). Requires minor bug fix to AbstractHibernateDSODAO to allow for additional OR/AND clauses to be appended. (cherry picked from commit f186dcf) * Add /epersons/search/isNotMemberOf endpoint to REST API along with integration tests (cherry picked from commit 5208a35) * Bug fix to EPersonDAOImpl. Correctly determine if excluded group needs to be preceded by AND or WHERE (cherry picked from commit e5e0eaa) * Updated IIIF Controller IT to text bitstream and bundle exclusions (cherry picked from commit e92b4b7) * Simplified the process of fixing the tests after adding new sidebar facets/search filters and sort options to discover.xml (cherry picked from commit b40ad0d) * 107671: Expose the handle.canonical.prefix to the frontend (cherry picked from commit 6d86e65) * Remove line breaks from default.license because they are being rendered in the frontend (cherry picked from commit 56aae34) * [Port dspace-7_x] subscription email: do not send email if nothing has changed (DSpace#9204) * improved subscriptions email template (cherry picked from commit 6e7b327) * do not send emails without content (cherry picked from commit 926b242) * fixed coding style violations (cherry picked from commit fdacec0) * removed unnecessary isEmpty check as suggested by reviewer (cherry picked from commit 30a837f) * moved null check on indexableObjects in generateBodyMail (cherry picked from commit b43c340) * fixed unhandled IOException (cherry picked from commit 9b3f7b6) * fixed typo in bodyCommunities (cherry picked from commit ac3d02e) * do not use != to compare strings (cherry picked from commit e460183) * fixed improper handling of empty list (cherry picked from commit ac72aae) --------- Co-authored-by: Sascha Szott <szott@gmx.de> * [maven-release-plugin] prepare release dspace-7.6.1 * Fixed checkstyle issues * Fixed compilation errors * Removed redundant service definitions in the `core-factory-services.xml` because unit tests was failing * Removed redundant bean in the `discovery.xml` * Removed redundant `latestVersion` from `schema.xml` * Fixed wrong resolved conflicts - the app cannot start running * Used ClarinVersionedHandleIdentifierProvider instead of Vanilla one in the `identifier-service.xml` * Fixed tests - the user has an authorization to remove bundle * Fixed failing test in the `MetadataExportSearchIT` it was trying to test dateIssued filter, but the CLARIN DSpace doesn't use that. * controlled.authority.dc.relation is changed in the configuration by CLARIN so the test VersioningWithRelationshipsIT is failing because of that. * Fixed wrong license validation class * Removed test which was accidentaly added durign resolving conflicts * The ACL tag restricted loading of some input field which was missing in the assert * The test cannot convert `Oct` from the xml to normal number because of Slovak default locale which doesn't know what `Oct` means in the date. I set up EN locale for the current test * Added clarin set up of search Facets into integration tests - because src/test/java/org/dspace/app/rest/DiscoveryScopeBasedRestControllerIT.java was failing * Added method `areSpecialGroupsApplicable` into ClarinShibAuthentication because after shib authentication the user wasn't assinged into special group because of some dspace new feature * Change DEFAULT_AMOUNT_FORMATS in the BitstreamFormatRestRepositoryIT.java because vanila has added a new format. * Ignored still failing RegistrationRestRepositoryIT test - it is ignored also in the 7.5 version * fix: Failure of org.dspace.app.rest.SitemapRestControllerIT when running locally * Ignore pubmedImportMetadataGetRecordsTest or allow ssl * Let the pubmedImportMetadataGetRecordsTests ignored * Fixed CurationIT - it failed on the Stream because Stream has null param. Null param was because of null handle on the Site object - the site handle was removed in the `ClarinHandleImportControllerIT.java#createHandleWithoutDSpaceObjectTest`. * Do not delete site handle in the HandleRestRepositoryIT * Updated scripts for fast building 7.6.1 * Moved flyway script for updating checksum_results into separate file * Added missing headers --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Sean Kalynuk <Sean.Kalynuk@umanitoba.ca> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Martin Walk <martin.walk@tu-berlin.de> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: David P. Steelman <dsteelma@umd.edu> Co-authored-by: Christian Bethge <54576195+ChrisBethgster@users.noreply.github.com> Co-authored-by: max.nuding <max.nuding@uni-konstanz.de> Co-authored-by: Max Nuding <max.nuding@icloud.com> Co-authored-by: Mark H. Wood <mwood@iu.edu> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Hrafn Malmquist <hrafn.malmquist@gmail.com> Co-authored-by: aroman-arvo <aroman@arvo.es> Co-authored-by: Christian Bethge <christian.bethge@bibliothek.uni-halle.de> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Mark Cooper <mark.c.cooper@outlook.com> Co-authored-by: nwoodward <woodward.nicholas@gmail.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Marie-Hélène Vézina <mhvezina@users.noreply.github.com> Co-authored-by: damian <damian.jozefowski@pcgacademia.pl> Co-authored-by: Gantner, Florian Klaus <florian.gantner@uni-bamberg.de> Co-authored-by: wwuck <wirelessduck@gmail.com> Co-authored-by: Paulo Graça <paulo1978@gmail.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: mohamed eskander <mohamed.eskander@4science.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: Luca Giamminonni <luca.giamminonni@4science.it> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: DSpace Bot <68393067+dspace-bot@users.noreply.github.com> Co-authored-by: Michael Spalti <mspalti@gmail.com> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Shankeerthan Kasilingam <shankeerthan1995@gmail.com> * The cas.init() method is called in the VocabularyRestRepositoryIT#setup() method * Update docker.yml (DSpace#502) dspace-dependencies job was missing * Update docker.yml (DSpace#503) Fixed dspace-dependencies error * Update docker.yml (DSpace#504) * Empty commit - run actions * use checkstyle before commit * remove fix duplicate dependency * remove discofeed related fetching from obsolete discojuice servers (DSpace#508) * remove discofeed related fetching from obsolete discojuice servers * check style, turned off in testing, turned of by default * fix failing test --------- Co-authored-by: jm <jm@maz> * ufal/cannot-upload-big-file (DSpace#533) * Do not compute localChecksum because it takes too long for the big files. The checksum is computed using DigestInputStream object. Copy content into sync local assetstore using buffered copying. * Fixed checkstyle issue * Updated comment about creating required directories * ufal/license-agreement-wrong-behaviour (DSpace#534) * The all transactions are not updated in the user metadata after a new download.. * Return the user metadata depending on user registration, bitstream, mapping and the last translation. * Fixed checkstyle issues * Fixed failing integration tests - do not fetch user metadata for testing by ID where there are more tests which creates the user metadata * internal/discofeed-it (DSpace#535) * Disable SSL check for specific discofeed requests * Fixed checkstyle issues * Do not throw error in private constructor * Fixed failing IT - ssl check wasn't disabled * Ignore integration test which is trying to connect to our private network. * allow running from branch rework-actions for testing * ufal/s3-check-etag (DSpace#537) * Temp commit - upload a file by uploading 50MB parts * Added uploading the file by parts - for every part is computed checksum and compared with UploadPartResult's ETag. This feature could be enabled or disabled by cfg. * Undo S3BitStoreService changes * Fixed checkstyle issues * Prettify the code * Changed cfg property to be better understandable and file size is converted into constant. * ufal/allow-impersonating Allow impersonating by default (DSpace#539) * correct branches for main gh actions * Rework actions (DSpace#540) * run correct actions on correct repos * remove old docker job, separating it to several * reusable build yml from upstream * upstream docker.yml version * first test run * steppify docker.yml action to be able to add more steps * added python version to reusable build * fix incorrect usage of steps in gh action * corect the type in reusable wf * correct condition in python version script * corrected the branch * corrected image dockerhub owner * no linux/arm64 * comment out unused tasks; minor corrections * do not redepoy becuse jm said so * do not use codecov * disable deploy differently * extend possibilities for using version script (DSpace#542) * parametrized output of python version script * RUUUN * correct version placement * correct branches for run of gh action * Fix all mistakes in the /home page (DSpace#543) * Configured browsing by language * Updated tests following the browsing cfg * reusable run provides links to run and it's ID * first attempt at tag release action * also release images under github.sha * Improve version info, add release-tag action add run link to version info correct image for tests (remove dspace-dependencies from migrate to 7.5) add action to release on tagging * add necessary option to tag-action * Fixed all mistakes in the Item View page (DSpace#551) * Remove the xml info and bibtex tag from the citation refbox * Show handle and DOI in the Item View following the new cfg property * Made updating xml string more generic * Updated the method name for the getting text content from the bibtex xml. * Fixed all mistakes in the Search page (DSpace#549) * File size in the MetadataBitstreamWrapperRest changed to `long` type instead of String, the FE transfer all bytes into readable form. * Changed default sorting options * Added a new search configuration for the homepage, because searching by `dc.date.accesioned` must be removed because of clarin requirements, but the homepage uses searching by `dc.date.accesioned` * Configured searching by Item Type in the search page. * Updated community indexing - added _filter and _keyword because they are needed to work as facet and filter * Updated `Rights` and `Community` configuration. Changed to `text` type. * Allow Site usage reports for the Anonymous user * Fixed MetadataBitstreamRestRepositoryIT - the Matcher has a problem to compare long types. * Fixed DiscoveryScopeBasedRestControllerIT - the expected facets and Matchers did must be updated. * Fixed ClarinDiscoveryRestControllerIT - the expected facets and Matchers did must be updated. * Use `dc.contributor.other` metadata field for mapping the authors (DSpace#557) * Added `edm.xml` registry (DSpace#559) * Added `edm.xml` registry * Fixed cfg for `edm.xml` * Updated shibboleth cfg properties (firstname, lastname, netid, email) (DSpace#558) * Updated shibboleth cfg properties (firstname, lastname, netid, email) * Keep vanilla shib headers for the integration tests * Removed duplicated code --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: Adán Román Ruiz <aroman@arvo.es> Co-authored-by: Ondřej Košarko <ko_ok@centrum.cz> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Luca Giamminonni <luca.giamminonni@4science.it> Co-authored-by: Sean Kalynuk <Sean.Kalynuk@umanitoba.ca> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Martin Walk <martin.walk@tu-berlin.de> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: David P. Steelman <dsteelma@umd.edu> Co-authored-by: Christian Bethge <54576195+ChrisBethgster@users.noreply.github.com> Co-authored-by: max.nuding <max.nuding@uni-konstanz.de> Co-authored-by: Max Nuding <max.nuding@icloud.com> Co-authored-by: Mark H. Wood <mwood@iu.edu> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Hrafn Malmquist <hrafn.malmquist@gmail.com> Co-authored-by: Christian Bethge <christian.bethge@bibliothek.uni-halle.de> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Mark Cooper <mark.c.cooper@outlook.com> Co-authored-by: nwoodward <woodward.nicholas@gmail.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Marie-Hélène Vézina <mhvezina@users.noreply.github.com> Co-authored-by: damian <damian.jozefowski@pcgacademia.pl> Co-authored-by: Gantner, Florian Klaus <florian.gantner@uni-bamberg.de> Co-authored-by: wwuck <wirelessduck@gmail.com> Co-authored-by: Paulo Graça <paulo1978@gmail.com> Co-authored-by: Toni Prieto <antonio.juan.prieto@upc.edu> Co-authored-by: mohamed eskander <mohamed.eskander@4science.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: Andrea Bollini <andrea.bollini@4science.it> Co-authored-by: DSpace Bot <68393067+dspace-bot@users.noreply.github.com> Co-authored-by: Michael Spalti <mspalti@gmail.com> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Shankeerthan Kasilingam <shankeerthan1995@gmail.com> Co-authored-by: jm <jm@maz> Co-authored-by: Jozef Misutka <332350+vidiecan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/DS-1917