Delete sync settings when disconnect from orcid

[floriangantner]

References

Add references/links to any related issues or PRs. These may include:

• Fixes Delete sync settings when profile is unlinked/disconnected from orcid #9390

Description

This PR introduces a new functionality to delete some profile orcid synchronization settings when the corresponding profile is unlinked from orcid.

Instructions for Reviewers

List of changes in this PR:

• boolean configuration orcid.disconnection.remain-sync = true whether the orcid synchronization metadata should remain in the profile when it is unlinked from orcid or whether they should by deleted. By default the synchronization settings remain in the profile
• additional check in the unlink method for this configuration which deletes in the clearSynchronizationSettings method the dspace.orcid.sync-mode , dspace.orcid.sync-profile and all dspace.orcid.sync-<entityType>+s, e.g. dspace.orcid.sync-publications metadatavalues

Include guidance for how to test or review your PR.

• Provided two integration tests checking if the sync options are deleted or not depending on the configuration setting.
• For testing: link some profile with orcid -> set orcid sync settings -> unlink profile from orcid -> depending on the configuration check if the profile still has the synchronization settings or if they have been deleted.
• Configurable option has been set true (or remain) by default. Delete sync settings when profile is unlinked/disconnected from orcid #9390 (comment)

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
• My PR passes Checkstyle validation based on the Code Style Guide.
• My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
• My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
• If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

@floriangantner : Could you rebase this on the latest main to verify ITs are now succeeding? This PR is showing a large number of IT failures, but they all appear to be unrelated. So, hopefully, after rebasing, these failures will all be fixed.

[tdonohue]

👍 Thanks @floriangantner ! I managed it give this a test today and it works. The code looks fine and the ITs prove the functionality works as well.