Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In facets, vertically align checkbox with first word of option #1711

Closed
alawvt opened this issue Jun 28, 2022 · 7 comments
Closed

In facets, vertically align checkbox with first word of option #1711

alawvt opened this issue Jun 28, 2022 · 7 comments
Labels
bug component: Discovery related to discovery search or browse system Estimate TBD good first issue This is a smaller ticket/bug that may be easier for new contributors help wanted Needs a volunteer to claim to move forward medium priority usability
Milestone

Comments

@alawvt
Copy link

alawvt commented Jun 28, 2022

Describe the bug DSpace 7.2?
As first reported in https://groups.google.com/g/dspace-community/c/GMO020isfZQ/m/1ISexkihAwAJ,
in facets, the check box for each option seems to be vertically centered on each option. This is fine for single lines but is confusing for multi-line options. For example, the ETD collection in the Iowa State University repository running DSpace 7.2, https://dr.lib.iastate.edu/collections/0830d32e-14e1-4a4f-bb8f-271a75ed35af?scope=0830d32e-14e1-4a4f-bb8f-271a75ed35af, offers a Department facet with the long option, Civil, Construction, and Environmental Engineering. I propose putting the check box inline with the first word of each option. I observe this in Firefox but not in Chrome or Safari. Attached are screenshots of each. [Note also that checkboxes in Safari overlap the text for some options.]


Firefox
Firefox_facet_checkbox


Chrome
Chrome_facet_checkbot


Safari
Safari_facet_checkbox


A clear and concise description of what the bug is. Include the version(s) of DSpace where you've seen this problem & what web browser you were using. Link to examples if they are public.

To Reproduce
Steps to reproduce the behavior:

  1. Do this
  2. Then this...

Expected behavior
A clear and concise description of what you expected to happen.

Related work
Link to any related tickets or PRs here.

@alawvt alawvt added bug needs triage New issue needs triage and/or scheduling labels Jun 28, 2022
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward usability component: Discovery related to discovery search or browse system high priority Estimate TBD and removed needs triage New issue needs triage and/or scheduling labels Jun 28, 2022
@tdonohue tdonohue added good first issue This is a smaller ticket/bug that may be easier for new contributors medium priority and removed high priority labels Jul 1, 2022
@ybnd
Copy link
Member

ybnd commented Aug 25, 2022

I'm seeing slightly different misalignment on Firefox 103.0.2
20220825-103353

@alawvt
Copy link
Author

alawvt commented Aug 25, 2022

Thanks, @ybnd, thank you for sharing your view. Is that a site that I could test? In Firefox 104.0, the page that I linked above still looks the same as the first screenshot.

@ybnd
Copy link
Member

ybnd commented Aug 25, 2022

@alawvt that was on the demo site: https://demo7.dspace.org/search
Now that you mention it, it does appear centered https://dr.lib.iastate.edu for me as well -- so it's probably due to the theme there?

@alawvt
Copy link
Author

alawvt commented Aug 25, 2022

Thanks, @ybnd, the subjects on the Demo site look fine for me, too. So maybe it is a theme issue at https://dr.lib.iastate.edu/. Therefore, I'd be fine with closing this issue, @tdonohue.

@ybnd
Copy link
Member

ybnd commented Aug 25, 2022

I'd suggest leaving it open since the default style in FF is still off compared to other browsers (just not vertically)
& we could look at the spacing issue on Safari as well

@alawvt
Copy link
Author

alawvt commented Aug 25, 2022

Ok. Here's Safari
DSpace7_facets_Safari
and Chrome.
DSpace7_facets_Chrome

@tdonohue
Copy link
Member

Closing, as alignment issues no longer exist in Firefox or Chrome or MS Edge. I suspect this was fixed in #2018 or some similar change in 7.5

@tdonohue tdonohue added this to the 7.6 milestone Jun 22, 2023
4science-it pushed a commit to 4Science/dspace-angular that referenced this issue May 17, 2024
[DSC-1514] Changed "cancel" button in Metadata registry & Bulk Access Management

Approved-by: Francesco Molinaro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: Discovery related to discovery search or browse system Estimate TBD good first issue This is a smaller ticket/bug that may be easier for new contributors help wanted Needs a volunteer to claim to move forward medium priority usability
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants