-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In facets, vertically align checkbox with first word of option #1711
Comments
Thanks, @ybnd, thank you for sharing your view. Is that a site that I could test? In Firefox 104.0, the page that I linked above still looks the same as the first screenshot. |
@alawvt that was on the demo site: https://demo7.dspace.org/search |
Thanks, @ybnd, the subjects on the Demo site look fine for me, too. So maybe it is a theme issue at https://dr.lib.iastate.edu/. Therefore, I'd be fine with closing this issue, @tdonohue. |
I'd suggest leaving it open since the default style in FF is still off compared to other browsers (just not vertically) |
Closing, as alignment issues no longer exist in Firefox or Chrome or MS Edge. I suspect this was fixed in #2018 or some similar change in 7.5 |
[DSC-1514] Changed "cancel" button in Metadata registry & Bulk Access Management Approved-by: Francesco Molinaro
Describe the bug DSpace 7.2?
As first reported in https://groups.google.com/g/dspace-community/c/GMO020isfZQ/m/1ISexkihAwAJ,
in facets, the check box for each option seems to be vertically centered on each option. This is fine for single lines but is confusing for multi-line options. For example, the ETD collection in the Iowa State University repository running DSpace 7.2, https://dr.lib.iastate.edu/collections/0830d32e-14e1-4a4f-bb8f-271a75ed35af?scope=0830d32e-14e1-4a4f-bb8f-271a75ed35af, offers a Department facet with the long option, Civil, Construction, and Environmental Engineering. I propose putting the check box inline with the first word of each option. I observe this in Firefox but not in Chrome or Safari. Attached are screenshots of each. [Note also that checkboxes in Safari overlap the text for some options.]
Firefox
Chrome
Safari
A clear and concise description of what the bug is. Include the version(s) of DSpace where you've seen this problem & what web browser you were using. Link to examples if they are public.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Related work
Link to any related tickets or PRs here.
The text was updated successfully, but these errors were encountered: