Skip to content

fix(filterrules): use cloneDeep replace clone #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(filterrules): use cloneDeep replace clone #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/filterRules/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { message } from 'antd';
import { InternalNamePath } from 'antd/lib/form/interface';
import { clone } from 'lodash-es';
import { cloneDeep } from 'lodash-es';
import shortId from 'shortid';

import useLocale from '../locale/useLocale';
Expand Down Expand Up @@ -89,7 +89,7 @@ const FilterRules = <T,>(props: IProps<T>) => {
};

const handleAddCondition = (keyObj: { key: string; isOut?: boolean }) => {
const cloneData = clone(value);
const cloneData = cloneDeep(value);
const appendNode = findRelationNode(cloneData as IFilterValue<T>, keyObj.key, keyObj.isOut);
addCondition(appendNode, keyObj, initValues as T);
onChange?.(cloneData);
Expand Down Expand Up @@ -150,7 +150,7 @@ const FilterRules = <T,>(props: IProps<T>) => {
};

const handleDeleteCondition = (key: string) => {
const cloneData = clone(value);
const cloneData = cloneDeep(value);
const deleteNode = findRelationNode(cloneData as IFilterValue<T>, key, false);
if (notEmpty.data && !deleteNode?.children) return message.info(notEmpty.message);
if (!notEmpty.data && !deleteNode?.children) {
Expand Down Expand Up @@ -192,7 +192,7 @@ const FilterRules = <T,>(props: IProps<T>) => {

// 更改条件节点的条件
const handleChangeCondition = (key: string, type: ROW_PERMISSION_RELATION) => {
const cloneData = clone(value);
const cloneData = cloneDeep(value);
const changeNode = findRelationNode(
cloneData as IFilterValue<T>,
key,
Expand All @@ -207,7 +207,7 @@ const FilterRules = <T,>(props: IProps<T>) => {

// 改变节点的的数据
const handleChangeRowValues = (key: string, values: T) => {
const cloneData = clone(value);
const cloneData = cloneDeep(value);
const changeNode = findRelationNode(
cloneData as IFilterValue<T>,
key,
Expand Down
Loading