rebase to future changes in main repo #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug that happens when trying to react to "header height" changes with WindowScroller. The documentation currently points to calling WindowScroller::updatePosition, however, while that updates the cached position on the WindowScroller instance variables, it does not update the scrollTop state variable. This causes virtual-lists linked to it to not properly render immediately after a header height change; only after a subsequent scroll event.
After further testing, I've found that after `handleWindowScrollEvent` is called we also need to force the `isScrolling` state variable to turn back to false (otherwise there might be issues with rendering rows that depend on `isScrolling`).
* Fix issue with unused import being emitted * Fix import
* Fix grid roles for accessbility * Add test for gridcell role
… to handle any downsream consequences.
MosheZemah
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to react-virtualized!
Before submitting a pull request, please complete the following checklist:
npm test) all passyarn run prettier).yarn run typecheck).Here is a short checklist of additional things to keep in mind before submitting: