[Sehwan] Week11 solution with JavaScript #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-jonghoonpark
approved these changes
Jul 11, 2024
sounmind
approved these changes
Jul 13, 2024
maximum-product-subarray/nhistory.js
Outdated
| let max = 1, | ||
| min = 1; | ||
|
|
||
| for (let num of nums) { |
There was a problem hiding this comment.
이렇게 작성하면, 이 코드를 읽을 때 num이 나중에 재할당 되는 건가~? 하는 생각을 하지 않을 수 있겠네요!
Suggested change
| for (let num of nums) { | |
| for (const num of nums) { |
다른 비슷한 사례는 생략할게요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.