Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 23 additions & 21 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,22 @@

https://discord.gg/6TwzdnW6ze

## ์Šคํ„ฐ๋”” ๋งด๋ฒ„
## ์Šคํ„ฐ๋”” ๋ฉค๋ฒ„

- ๋ฆฌ๋” 1: [Bumsu-Yi](https://github.com/Bumsu-Yi)
- ๋ฆฌ๋” 2: [leokim0922](https://github.com/leokim0922)
- ๋งด๋ฒ„ 1: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
- ๋งด๋ฒ„ 2: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
- ๋งด๋ฒ„ 3: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
- ๋งด๋ฒ„ 4: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
- ๋งด๋ฒ„ 5: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
- ๋งด๋ฒ„ 6: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
https://github.com/DaleStudy/leetcode-study/issues/7

## ๋‹ต์•ˆ ์ฝ”๋“œ ์ž‘์„ฑ๋ฒ•
์ฐธ์กฐ ๋งํฌ :
https://seongjin.me/how-to-contribute-to-open-source/amp/

`main` ๋ธŒ๋žœ์น˜์—์„œ ์ตœ์‹  ์ฝ”๋“œ๋ฅผ ๋‚ด๋ ค ๋ฐ›์€ ํ›„์—, `<์ฃผ>-<GitHub ์œ ์ €๋„ค์ž„>` ํ˜•ํƒœ๋กœ ๋ธŒ๋žœ์น˜๋ฅผ ๋•๋‹ˆ๋‹ค.

์˜ˆ๋ฅผ ๋“ค์–ด,
๋จผ์ €, ํ˜„์žฌ ํŽ˜์ด์ง€ ์šฐ์ƒ๋‹จ์— ์žˆ๋Š” ๋ฒ„ํŠผ๋“ค ์ค‘ `Fork` ๋ฒ„ํŠผ ํด๋ฆญํ•˜์—ฌ ๊ฐœ์ธ ์›๊ฒฉ ์ €์žฅ์†Œ๋กœ ๋ณต์‚ฌํ•ด์ค๋‹ˆ๋‹ค.

๊ฐœ์ธ ๋กœ์ปฌ ์ €์žฅ์†Œ๋กœ `Fork`ํ•œ ๊ฐœ์ธ ์›๊ฒฉ ์ €์žฅ์†Œ ์ฝ”๋“œ๋ฅผ ํด๋ก ํ•ฉ๋‹ˆ๋‹ค,

์˜ˆ๋ฅผ ๋“ค์–ด,
```sh
$ git pull
$ git checkout -b week1-bumsu-yi
$ git clone https://github.com/Bumsu-Yi/leetcode-study.git
```

ํ‘ธ์‹œ๋ ค๋Š” ๋ฌธ์ œ์˜ ํด๋”์—์„œ ์ž๊ธฐ GitHub ์œ ์ €๋„ค์ž„์œผ๋กœ ํŒŒ์ผ์„ ์ƒ์„ฑํ•ฉ๋‹ˆ๋‹ค.
Expand All @@ -44,22 +40,28 @@ $ touch Bumsu-Yi.py
์˜ˆ๋ฅผ ๋“ค์–ด,

```sh
$ git add Bumsu_Yi.py
$ git commit -am "two sum solution"
```

## ๋‹ต์•ˆ ์ฝ”๋“œ ์ œ์ถœ๋ฒ•

์ž‘์„ฑํ•œ ๋‹ตํ•œ ์ฝ”๋“œ์— ๋Œ€ํ•ด์„œ ๋‹ค๋ฅธ ์Šคํ„ฐ๋”” ๋งด๋ฒ„๋กœ ๋ถ€ํ„ฐ ๋ฆฌ๋ทฐ๋ฅผ ๋ฐ›๊ณ  ์‹ถ๋‹ค๋ฉด ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์ €์žฅ์†Œ์— ์˜ฌ๋ฆฝ๋‹ˆ๋‹ค.
์ž‘์„ฑํ•œ ๋‹ตํ•œ ์ฝ”๋“œ๋ฅผ ๊ฐœ์ธ ์›๊ฒฉ ์ €์žฅ์†Œ๋กœ push ํ•ฉ๋‹ˆ๋‹ค.

```sh
$ git push origin week1-bumsu-yi
$ git push origin main
```

๊ทธ๋ฆฌ๊ณ  ๋ธŒ๋ผ์šฐ์ €์—์„œ ์ฝ”๋“œ ์ €์žฅ์†Œ๋ฅผ ๋ฐฉ๋ฌธํ•˜๋ฉด Pull Request๋ฅผ ์ƒ์„ฑํ•˜๋ผ๊ณ  ๋œฐ ๊ฒƒ์ž…๋‹ˆ๋‹ค.
๊ทธ ๋ฒ„ํŠผ์„ ํด๋ฆญํ•˜๊ณ  Pull Request๋ฅผ ์ƒ์„ฑํ•ฉ๋‹ˆ๋‹ค.
๊ทธ๋Ÿฌ๋ฉด ๋””์Šค์ฝ”๋“œ ์ฑ„๋„์— ์•Œ๋žŒ์ด ์˜ฌ๋ผ์˜ฌ ๊ฒƒ์ž…๋‹ˆ๋‹ค.
๊ทธ ๋‹ค์Œ, ๊นƒํ—ˆ๋ธŒ ์›น์‚ฌ์ดํŠธ ๊ฐœ์ธ ์›๊ฒฉ์ €์žฅ์†Œ์— ๋“ค์–ด๊ฐ€ ์ขŒ์ƒ๋‹จ `Pull request`๋ฅผ ๋ˆ„๋ฅด๊ณ  `Pull request` ํƒญ์œผ๋กœ ์ด๋™ํ•œ ๋’ค, `New pull request` ๋ฒ„ํŠผ์„ ํด๋ฆญํ•ด์ค๋‹ˆ๋‹ค.

Pull Request ์„ค๋ช…๋ž€์— ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์–ด๋ ค์› ๋˜ ๋ถ€๋ถ„์ด๋‚˜ ๋„์›€์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์— ๋Œ€ํ•ด์„œ ๋‚จ๊ฒจ์ฃผ์‹œ๋ฉด ๋‹ค๋ฅธ ๋ถ„๋“ค์ด ๋ฆฌ๋ทฐํ•  ๋•Œ ์ฐธ๊ณ ํ•  ์ˆ˜ ์žˆ์–ด์„œ ์ข‹๊ฒ ์ฃ ?
์ด์ œ ์ž‘์—…ํ•œ ์ฝ”๋“œ๋ฅผ ์›๋ณธ ์›๊ฒฉ ์ €์žฅ์†Œ๋กœ 'Merge' ํ•˜๊ธฐ ์œ„ํ•œ 'PR'์„ ์ƒ์„ฑํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

`Create pull request` ๋ฅผ ๋ˆ„๋ฅด๊ธฐ์— ์•ž์„œ, ์ƒ๋‹จ์— ์žˆ๋Š” `base repository` ์™€ `head repositry` ๊ฐ€ ๊ฐ๊ฐ ์›๋ณธ ์›๊ฒฝ ์ €์žฅ์†Œ์˜ main ๋ธŒ๋ Œ์น˜์™€ ๋ณธ์ธ์ด ์ž‘์—…ํ•œ ๋ธŒ๋ Œ์น˜๊ฐ€ ๋งž๋Š” ์ง€ ํ™•์ธํ•ด์ค๋‹ˆ๋‹ค.

๋ฆฌ๋ทฐ๋ฅผ ๋ฐ›๋Š” ๋™์•ˆ ๋‹ต์•ˆ ์ฝ”๋“œ๋Š” ์–ผ๋งˆ๋“ ์ง€ ์ถ”๊ฐ€ ์ž‘์„ฑํ•ด์„œ commit/push ํ•˜์‹ค ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
push ํ•˜์‹œ๋Š” ์ฝ”๋“œ๋Š” ์ƒ์„ฑํ•œ Pull Request์— ๋ฐ”๋กœ ๋ฐ˜์˜์ด ๋  ๊ฒƒ์ž…๋‹ˆ๋‹ค.
ํ™•์ธ์ด ๋˜์—ˆ์œผ๋ฉด, `Create pull request`๋ฅผ ๋ˆ„๋ฅด๊ณ , `Title`์— ๋ณธ์ธ์˜ ๋””์Šค์ฝ”๋“œ ๋‹‰๋„ค์ž„์„ ํฌํ•จ ์‹œ์ผœ์ฃผ๊ณ  `Create pull request` ๋ฒ„ํŠผ์„ ํด๋ฆญํ•ฉ๋‹ˆ๋‹ค.

๊ทธ๋Ÿฌ๋ฉด ๋””์Šค์ฝ”๋“œ์—๋„ ์•Œ๋ฆผ์ด ์˜ฌ๊ฒ๋‹ˆ๋‹ค.

์ด์ œ ๋ณธ์ธ์ด ์ž‘์„ฑํ•œ ์†”๋ฃจ์…˜์„ ๋ฆฌ๋ทฐ ๋ฐ›์„ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ๋ฆฌ๋ทฐ๊ฐ€ `approved` ๋œ๋‹ค๋ฉด ๋ฉ”์ธ ์ €์žฅ์†Œ๋ฅผ `Merge` ํ•˜์‹ค ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

Pull Request ์„ค๋ช…๋ž€์— ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์–ด๋ ค์› ๋˜ ๋ถ€๋ถ„์ด๋‚˜ ๋„์›€์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์— ๋Œ€ํ•ด์„œ ๋‚จ๊ฒจ์ฃผ์‹œ๋ฉด ๋‹ค๋ฅธ ๋ถ„๋“ค์ด ๋ฆฌ๋ทฐํ•  ๋•Œ ์ฐธ๊ณ ํ•  ์ˆ˜ ์žˆ์–ด์„œ ์ข‹๊ฒ ์ฃ ?