Skip to content

Conversation

hyejjun
Copy link
Contributor

@hyejjun hyejjun commented Aug 29, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@hyejjun hyejjun added the js label Aug 29, 2024
@hyejjun hyejjun requested a review from a team as a code owner August 29, 2024 09:32
@hyejjun hyejjun changed the title Two Sum [이혜준] Week3 문제 풀이 Aug 29, 2024
@hyejjun hyejjun marked this pull request as draft August 29, 2024 09:34
@hyejjun hyejjun assigned taekwon-dev and hyejjun and unassigned hyejjun and taekwon-dev Aug 29, 2024
@hyejjun hyejjun requested a review from taekwon-dev August 29, 2024 09:36
Comment on lines +6 to +14
var twoSum = function (nums, target) {
for (let i = 0; i < nums.length; i++) {
for (let j = i + 1; j < nums.length; j++) {
if (nums[i] + nums[j] === target) {
return [i, j];
}
}
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요! 적절한 자료구조를 활용해서 더 효율적인 방식으로 풀어볼 수 있을 것 같아요.
저는 이런 문제 풀 때 특히 주어진 배열의 원소를 꼭 다 활용하는 형태여야 하는가? 라는 질문을 스스로 던져보는데, 한 번 고민해보시면 좋을 것 같습니다.!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 의견 감사합니다. 자료구조 활용하는 방법을 고민해보겠습니다!

@bky373
Copy link
Contributor

bky373 commented Aug 29, 2024

안녕하세요~ 이제 자동 워크플로 통해 언어 label 이 붙을 거라 직접 추가해주지 않으셔도 됩니다!

@hyejjun hyejjun marked this pull request as ready for review August 30, 2024 01:36
Copy link
Member

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@hyejjun hyejjun merged commit fa8a2f3 into DaleStudy:main Aug 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants