[jj7779607] Week1 #637
Merged
[jj7779607] Week1 #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DaleStudy/coach |
|
안녕하세요 @limlimjo 님! |
DaleSeo
approved these changes
Dec 12, 2024
|
|
||
| // 시간복잡도와 공간복잡도 | ||
| // 시간복잡도: 배열의 길이 n 만큼 for문 순회하므로 -> O(n) | ||
| // 공간복잡도: nums 배열 그대로 수정하여 계산 -> O(1) |
There was a problem hiding this comment.
입력 배열을 재활용하셔서 메모리를 절약하시는 게 알고리즘 고수 같기도 하고 뭔가 멋지게 느껴집니다 😎
There was a problem hiding this comment.
아닙니다ㅜㅜ 완전 알고리즘 초보입니다ㅜㅜ
리뷰 감사합니다!
| } | ||
|
|
||
| nums.sort((a, b) => a - b); // 오름차순으로 정렬 | ||
| console.log(nums); |
There was a problem hiding this comment.
console을 찍어넣고 제거를 하지 못했네요
| }; | ||
|
|
||
| // 여기서 위 코드의 시간복잡도와 공간복잡도를 생각해보자... | ||
| // 시간복잡도 => O(m log m) ** 더 개선할 방법 찾아보기 |
There was a problem hiding this comment.
아직 못 찾아 풀이와 다른 분들의 풀이 방법을 참고하려고 합니다!
Comment on lines
+18
to
+21
| return true; | ||
| } else { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
(안 중요) 요리하면 더 간단하지 않았을까 생각이 들었습니다.
Suggested change
| return true; | |
| } else { | |
| return true; | |
| } | |
| } | |
| return true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크 리스트
In Review로 설정해주세요.