Skip to content

Conversation

ysle0
Copy link
Contributor

@ysle0 ysle0 commented Dec 5, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@ysle0 ysle0 added the go label Dec 5, 2024
@ysle0 ysle0 requested a review from limlimjo December 5, 2024 10:47
@ysle0 ysle0 self-assigned this Dec 5, 2024
@ysle0 ysle0 requested a review from a team as a code owner December 5, 2024 10:47
Copy link
Contributor

@HC-kang HC-kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysle0 님, 첫 주차 고생하셨습니다!

문제풀이와 분석도 읽기 쉽게 잘 써주시고, 주석도 정말 잘 남겨주셔서 보면서 많이 배웠네요.
앞으로도 좋은 풀이 많이 남겨주시면 좋겠습니다!!

return false
}

func containsDuplicate_SortedApproach(nums []int) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정렬 후 중복을 확인하는 부분에 대해서도 복잡도 분석을 해주시면 좋을 것 같아요
각각의 장단점을 확실하게 명시할 수 있지 않을까요?

cursor++
}

//tmp := make([]int, 0, len(cons))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요하다면 제거하는게 좋지 않을까요? 🧹

return x
}

func topKFrequentElements_BucketSort(nums []int, k int) []int {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

res = append(res, buc[i]...)
}

return res[:k]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막 슬라이싱은 불필요하지 않을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 그렇네요

@ysle0
Copy link
Contributor Author

ysle0 commented Dec 10, 2024

@HC-kang 코드리뷰 정말 도움이 많이 되었습니다!
감사합니다

@ysle0 ysle0 merged commit 6e112ea into DaleStudy:main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants