Skip to content

[호돌이] Week 1 #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 15, 2024
Merged

[호돌이] Week 1 #682

merged 9 commits into from
Dec 15, 2024

Conversation

yeeZinu
Copy link
Contributor

@yeeZinu yeeZinu commented Dec 11, 2024

답안 제출 문제

3주차 문제지만 제일 쉬운 것 같아 처음 도전해봤습니다!

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@yeeZinu yeeZinu added the js label Dec 11, 2024
@yeeZinu yeeZinu self-assigned this Dec 11, 2024
@yeeZinu yeeZinu requested a review from a team as a code owner December 11, 2024 11:59
@yeeZinu yeeZinu requested a review from crumbs22 December 11, 2024 12:02
@HC-kang
Copy link
Contributor

HC-kang commented Dec 11, 2024

안녕하세요 @yeeZinu 님!
제출해주신 풀이 마지막에 개행문자가 누락된것같아요.
개행문자 추가후에도 CI워크플로우에 문제가 있다면 아래 링크를 확인 해 주세요!

#664 (comment)

Comment on lines +10 to +11
return nums.length !== new Set(nums).size
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 for문을 통해 배열을 돌면서 겹치는 게 있는지 검사했는데 size로 검사하는 걸 생각 못했네요, 배워갑니다! 🔥

@yeeZinu yeeZinu merged commit 5ac3e9a into DaleStudy:main Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants