[HodaeSsi] Week 5 #883
Merged
[HodaeSsi] Week 5 #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgonD3V
approved these changes
Jan 12, 2025
Comment on lines
+4
to
+12
| def maxProfit(self, prices: List[int]) -> int: | ||
| min_price = float('inf') | ||
| max_profit = 0 | ||
|
|
||
| for price in prices: | ||
| min_price = min(min_price, price) | ||
| max_profit = max(max_profit, price - min_price) | ||
|
|
||
| return max_profit |
There was a problem hiding this comment.
알고리즘이 간결하고 이쁘네요. 다만 가독성을 위해 indent는 4space를 추천드립니다.
Comment on lines
+3
to
+6
|
|
||
| class Solution: | ||
| def groupAnagrams(self, strs: List[str]) -> List[List[str]]: | ||
| anagrams = collections.defaultdict(list) |
There was a problem hiding this comment.
Suggested change
| class Solution: | |
| def groupAnagrams(self, strs: List[str]) -> List[List[str]]: | |
| anagrams = collections.defaultdict(list) | |
| from collections import defaultdict | |
| class Solution: | |
| def groupAnagrams(self, strs: List[str]) -> List[List[str]]: | |
| anagrams = defaultdict(list) |
파이썬에서 보통은 이런 식으로 모듈을 import 하는데, 이러면 어떤 모듈을 사용하는 파일인지 알기 쉬워져서 가독성이 더 좋아질 것 같습니다
| def groupAnagrams(self, strs: List[str]) -> List[List[str]]: | ||
| anagrams = collections.defaultdict(list) | ||
| for word in strs: | ||
| anagrams[''.join(sorted(word))].append(word) |
There was a problem hiding this comment.
Suggested change
| anagrams[''.join(sorted(word))].append(word) | |
| key = ''.join(sorted(word)) | |
| anagrams[key].append(word) |
코딩 골프 느낌의 pythonic한 짧은 코드도 좋지만, 해당 임시 변수가 어떤 역할을 하는지 선언한 변수명으로 알려주면 좋을 것 같습니다.
| # 시간복잡도 : O(n^2) | ||
| # 공간복잡도 : O(n) | ||
| class Solution: | ||
| def wordBreak(self, s: str, wordDict: List[str]) -> bool: |
There was a problem hiding this comment.
사실 이 문제는 위의 implement-trie-prefix-tree와 연관되어 있어서 이를 활용하여 풀어보시면 도움이 되실 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.