[친환경사과] Week 6 #900
Merged
[친환경사과] Week 6 #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmyeon
reviewed
Jan 17, 2025
Comment on lines
+15
to
+26
| if (element == ')' || element == ']' || element == '}') { | ||
| if (stack.isEmpty()) { | ||
| return false | ||
| } else if (stack.last() == '(' && element == ')') { | ||
| stack.removeAt(stack.lastIndex) | ||
| } else if (stack.last() == '[' && element == ']') { | ||
| stack.removeAt(stack.lastIndex) | ||
| } else if (stack.last() == '{' && element == '}') { | ||
| stack.removeAt(stack.lastIndex) | ||
| } else { | ||
| return false | ||
| } |
There was a problem hiding this comment.
괄호 짝인지 비교한 뒤 stack에서 제거 하는 로직이 반복되고 있어서,
괄호 짝을 객체나 Map에 정의한 뒤 키 값에 대응하는 값을 찾으면 중첩을 좀 더 줄일 수 있을 것 같아요
코틀린이 낯설어서 자바스크립트 코드 예시 첨부합니다 ~
const matchingBrackets: Record<string, string> = {
")": "(",
"}": "{",
"]": "[",
};There was a problem hiding this comment.
주석이 꼼꼼히 작성되어 있어서 리뷰하는 데 큰 도움이 되었어요.
더 나은 방법 찾으시는 모습이 멋지네요! 😃
Comment on lines
+43
to
+58
| fun maxArea02(height: IntArray): Int { | ||
| var maxValue = 0 | ||
| var left = 0 | ||
| var right = height.size - 1 | ||
| while (left <= right) { | ||
| val width = right - left | ||
| val containerHeight = Math.min(height[left], height[right]) | ||
| val area = width * containerHeight | ||
| maxValue = Math.max(maxValue, area) | ||
| if (height[left] < height[right]) { | ||
| left++ | ||
| } else { | ||
| right-- | ||
| } | ||
| } | ||
| return maxValue |
| * https://www.youtube.com/watch?v=TohdsR58i3Q 동영상 참조 | ||
| * trie 알고리즘을 사용한 문제 해결 | ||
| * 시간 복잡도: O(L * 26) | ||
| * -> addWord() 의 경우, 각 노드는 최대 26개의 노드를 가질 수 있으며 단어의 길이가 L이라면 O(L)의 시간 소요: O(L) |
There was a problem hiding this comment.
오! Trie 한 노드에서 가능한 자식 노드는 알파벳 개수 최대 26개로 제한되는군요!
중복된 알파벳은 기존 노드 재활용한다는 점 덕분에 새로 배워갑니다!
알려주셔서 감사합니다 👍
TonyKim9401
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.