[Helena] Week 4 solutions #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yolophg
commented
May 25, 2024
yolophg
commented
- Number of 1 Bits
- Counting Bits
- Reverse Bits
- Missing Number
- Group Anagrams
WhiteHyun
approved these changes
May 26, 2024
| } | ||
|
|
||
| // convert to unsigned integer. | ||
| return result >>> 0; |
There was a problem hiding this comment.
>>>가 right shift 연산이라면, 0을 해야하는 이유가 있는건지 궁금해요.
이미 result는 양수의 값을 갖고 있으므로 unsigned integer로 만들 것 없이 그냥 반환해도 괜찮지 않을까 생각이 들었거든요.
(JS를 몰라서 제가 예단하고 있는 거겠지만요 ㅎㅎ)
만약 하지 않았을 경우 잘못된 정답이 리턴될 수도 있나요?
nhistory
reviewed
May 26, 2024
| const count = new Array(26).fill(0); | ||
| // increment the count for each character. | ||
| for (const char of str) { | ||
| count[char.charCodeAt(0) - 'a'.charCodeAt(0)]++; |
There was a problem hiding this comment.
ASCII 코드를 활용해서 인덱스 값을 주는 방법도 가능하군요!
좋은 접근방법인 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.