VS 2017 Build - Making things work #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of work on the NuGet side, project re-arranging, and manual includes control - I think we have a working VS 2017 tooling build (using a pre-release
NuGet.Build.Tasks.Packwith fixes - see NuGet/Home#4853 for details).This fixes the missing
<frameworkAssemblies>in the current VS 2017 build, a problem across all libraries with any needed. Other changes:dotnet xunit.StrongName.csprojprojects into their own folder (current tooling cannot reasonably shareobj)build.cmdbecause holy fuck I'm tired of switching shellssemver.txtversioning modelappveyor.ymlsupport next