Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rewrite AMF and property behavior logic to use smart pointers, references, and string_views over raw pointers and std::string& #1452

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

refactor: Rewrite AMF and property behavior logic to use smart pointers, references, and string_views over raw pointers and std::string& #1452

wants to merge 26 commits into from

Commits on Feb 11, 2024

  1. Rewrite AMF and behavior logic to use smart pointers, references, and… 

    … string_views over raw pointers and std::string&
    @jadebenn
    jadebenn committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    fca5623 View commit details
    Browse the repository at this point in the history

  2. fix m_BehaviorID initialization

    @jadebenn
    jadebenn committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    acd601f View commit details
    Browse the repository at this point in the history

  3. Fix BlockDefinition member naming

    @jadebenn
    jadebenn committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c75cef2 View commit details
    Browse the repository at this point in the history

  4. remove redundant reset()s

    @jadebenn
    jadebenn committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    07b5135 View commit details
    Browse the repository at this point in the history

  5. Replace UB forward template declarations with header include

    @jadebenn
    jadebenn committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    7e036a3 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into AMFUniquePtrs

    @jadebenn
    jadebenn committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    08608c7 View commit details
    Browse the repository at this point in the history

  7. remove unneeded comment

    @jadebenn
    jadebenn committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    b8498c3 View commit details
    Browse the repository at this point in the history

  8. remove non-const ref getters

    @jadebenn
    jadebenn committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    1bb82b8 View commit details
    Browse the repository at this point in the history

  9. simplify default behavior id initialization

    @jadebenn
    jadebenn committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    b89488b View commit details
    Browse the repository at this point in the history

  10. Fix invalidated use of Getter to set a value

    @jadebenn
    jadebenn committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    0f1922a View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Update AddStripMessage.cpp - change push_back to emplace_back

    @jadebenn
    jadebenn committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    ab5ed7d View commit details
    Browse the repository at this point in the history

  2. fix pointer to ref conversion mistake (should not have directly grabb… 

    …ed from the other branch commit)
    @jadebenn
    jadebenn committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    188462e View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. deref

    @jadebenn
    jadebenn committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    797eeb5 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. VERY experimental testing of forward declaration of templates - proba… 

    …bly will revert
    @jadebenn
    jadebenn authored Feb 18, 2024
    Configuration menu
    Copy the full SHA
    e381ef7 View commit details
    Browse the repository at this point in the history

  2. Revert changes (as expected)

    @jadebenn
    jadebenn authored Feb 18, 2024
    Configuration menu
    Copy the full SHA
    b2b21a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Merge remote-tracking branch 'upstream/main' into AMFUniquePtrs

    @jadebenn
    jadebenn committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2798ee2 View commit details
    Browse the repository at this point in the history

  2. Update BlockDefinition.h - remove extraneous semicolons

    @jadebenn
    jadebenn authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    cee38f5 View commit details
    Browse the repository at this point in the history

  3. Update BlockDefinition.h - remove linebreak

    @jadebenn
    jadebenn authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c9f2b31 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Merge remote-tracking branch 'upstream/main' into AMFUniquePtrs

    @jadebenn
    jadebenn committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    f5e9bd8 View commit details
    Browse the repository at this point in the history

  2. Update Amf3.h member naming scheme

    @jadebenn
    jadebenn committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    2d7165a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/AMFClassNaming' into AMFUnique… 

    …Ptrs
    @jadebenn
    jadebenn committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    9bb5089 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into AMFUniquePtrs

    @jadebenn
    jadebenn committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    7cfc10c View commit details
    Browse the repository at this point in the history

  5. fix duplicated code

    @jadebenn
    jadebenn committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    da613ad View commit details
    Browse the repository at this point in the history

  6. const iterators

    @jadebenn
    jadebenn committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    939eb61 View commit details
    Browse the repository at this point in the history

  7. const pointers

    @jadebenn
    jadebenn committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    9f8cff8 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Merge remote-tracking branch 'upstream/main' into AMFUniquePtrs

    @jadebenn
    jadebenn committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    cf569f7 View commit details
    Browse the repository at this point in the history