-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dartdoc tooltips are not rendered as expected #41
Comments
@devoncarew recently made a bunch of changes that I think covers this. I might push another build to the marketplace tomorrow if I get some time to finish a few more things. Thanks for the feedback! |
See #26 for details/screenshot. |
Awesome! |
I guess this can be considered a dupe then. Do post back if after the update you think it needs more attention! |
The blank lines are being removed by Code :( I've raised microsoft/vscode#10311 to see what MS say. The other issue seems to be a weird bug; I've posted in the Analysis Server group to try and understand what's happening. |
Microsoft have fixed the blank lines disappearing for the next version (presumably in next insiders release too, but I'm not sure how often that updates, I don't use it yet). Still awaiting a response from the other issue; it seems like it might be a cache invalidation issue or something in the Dart analysis service so I'm hoping Google can confirm or suggest what I might be doing wrong. |
MS have fixed the newlines vanishing and Google have fixed the issues causing tooltips to sometimes show stale data. These will be in future (hopefully next) updates to VS Code and the Dart SDK :-) |
Probably makes sense to keep external issues open until they're dealt with to avoid duplicates being opened (and as a reminder there's something we want to do that is waiting on something else). Both the issues involved here are fixed but there hasn't been a new Code or SDK release yet. |
We can fix this by sending code blocks as |
I think the fix for this has introduced far more spacing than intended; I think we're waiting on microsoft/vscode#10311 (comment) again for now. |
The issue in code is actually only affecting lists; the other stuff we can already fix (but we'll need to detect code blocks to mark them up as Dart). |
This is back with MS; two reasons:
|
Considering this done now. MS intend to ship VS Code 1.5 today and 1.19 SDK is already out. Hovers are going to get an overhaul soon (in Code, and then Dart Code) so things will improve further in a future version. |
Currently the tooltips stack the doc comment and type, one right after the other. I think it would be easier to read if there was an extra new line between them.
Also It would be nice if the doc comments were formatted via markdown.
The text was updated successfully, but these errors were encountered: