Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non 0 PST for SegmentTimeline VOD will fail #1275

Closed
dsparacio opened this issue Mar 23, 2016 · 1 comment
Closed

Non 0 PST for SegmentTimeline VOD will fail #1275

dsparacio opened this issue Mar 23, 2016 · 1 comment
Labels
Bug
Milestone
2.1.0

Comments

@dsparacio
Copy link
Contributor

if either video or audio PST is non 0 and SegmentTimeline static the code in playback controller to capture commonEarliestTime on bytesAppended will fail. With SegmentTimeline we already know if the PST is 0 or not. I modified handler to expose the current segment list and we check that at getStartTime.
@dsparacio dsparacio added the Bug label Mar 23, 2016
@dsparacio dsparacio added this to the 2.1.0 milestone Mar 23, 2016
@dsparacio dsparacio mentioned this issue Mar 23, 2016
Closed
dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Mar 23, 2016
Fix for issue Dash-Industry-Forum#1275
67e361a
@dsparacio
Copy link
Contributor Author

Fixed with PR #1276

dsparacio pushed a commit that referenced this issue Mar 23, 2016
Merge pull request #1276 from AkamaiDASH/development
5bb6a20 
Fix for issue #1275
@dsparacio dsparacio mentioned this issue Mar 25, 2016
Merged
dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Mar 25, 2016
Fixed issue from PR that fixed Dash-Industry-Forum#1275. May also fix D…
5f124eb 
…ash-Industry-Forum#1273
dsparacio pushed a commit that referenced this issue Mar 25, 2016
Merge pull request #1287 from AkamaiDASH/development
499fda1 
Fixed issue from PR that fixed #1275. May also fix #1273
nickygerritsen pushed a commit to StreamOneNL/dash.js that referenced this issue Mar 30, 2016
Merge branch 'development' into s1-release
0ae18d3 
* development: (31 commits)
  Dash-Industry-Forum#1288 Fix for initial track selection with the correct setting check.
  Tweak latency capping in function of dvrWindowSize: dvrWindowSize/2 was too limiting for longer manifests
  Add sample page with alternate way to specify latency: setLiveDelay
  Fix sample page indentation
  Fix mismatched tags in sample page
  Clear clearBuffer timeout when resetting the player Make sure this timeout is never set more than once at a time
  Fixed issue from PR that fixed Dash-Industry-Forum#1275. May also fix Dash-Industry-Forum#1273
  Extracts other decideSegList to SegUtils as well. Addition to Dash-Industry-Forum#1279
  clean up minBufferTime in BufferController
  fix lint errors
  [FIX] if only one div is empty in the subtitle body, subtitles were not displayed.  example :  <div region="r0"  <p xml:id="sub59000" begin="00:00:59.000" end="00:01:00.000" >         <span style="s2">eng : 00:00:59.000</span>       </p>  </div>  <div region="r0"/>
  Code simplification
  Add alternative way to specify live latency in seconds
  Fix for failing initial index on segment timeline
  extracted decideSegmentListRangeForTemplate method to SegmentsUtil
  Fix for unwanted request to time 0 on live stream at startup.
  Fix for issue Dash-Industry-Forum#1275
  Update readme.md
  made availabilityUpperLimit configurable through method param
  extracted segment getting classes from DashHandler.js
  ...
davemevans pushed a commit to davemevans/dash.js that referenced this issue Apr 4, 2016
@davemevans
Fixed issue from PR that fixed Dash-Industry-Forum#1275. May also fix D…
cde5009 
…ash-Industry-Forum#1273
dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Apr 6, 2016
Removes race condition introduced while trying to fix Dash-Industry-F…
1c568f6 
…orum#1275.  This should solve that issue.
dsparacio pushed a commit that referenced this issue Apr 6, 2016
Merge pull request #1307 from AkamaiDASH/bugfixes
4161544 
Removes race condition introduced while trying to fix #1275.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@dsparacio