Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextTrack::deleteTrackCues - Wrong object passed from TextController #1922

Closed
jeremco opened this issue May 10, 2017 · 0 comments
Closed

TextTrack::deleteTrackCues - Wrong object passed from TextController #1922

jeremco opened this issue May 10, 2017 · 0 comments

Comments

@jeremco
Copy link
Contributor

jeremco commented May 10, 2017

When changing current text track, in TextController, TextTracks::deleteTrackCues is called using MediaController track object, whereas the method wait for an HTML TextTrack object.

In this case, the cues are not deleted from HTML TextTrack object
jeremco added a commit to Orange-OpenSource/dash.js that referenced this issue May 10, 2017
@jeremco
Fix issue Dash-Industry-Forum#1922: TextTrack::deleteTrackCues - Wron…
d8b970c 
…g object passed from TextController
@jeremco jeremco mentioned this issue May 10, 2017
Merged
TobbeEdgeware pushed a commit that referenced this issue May 10, 2017
@tobbee
Merge pull request #1923 from Orange-OpenSource/Issue_1922_DeleteTrac…
35b4fe6 
…kCues

Fix issue #1922: TextTrack::deleteTrackCues - Wrong object passed from TextController
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TobbeEdgeware @jeremco