Fix CC packet sorting #1907
Merged
Fix CC packet sorting #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sorting CC packets, those that are received at the same time should be ordered by the order in which they were receiving, such that correct ordering will be maintained when displaying them.
squarebracket
force-pushed
the
fix-cc-packet-sorting
branch
from
4bde2e2
to
c290d77
Compare
|
@squarebracket Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sorting CC packets, those that are received at the same time
should be ordered by the order in which they were receiving, such that
correct ordering will be maintained when displaying them.
Otherwise you end up with garbled captions being displayed.