Fix a bug in ObjectUtils::areSimpleEquivalent method

[jeremco]

If objects have same parameters but declared in a different order, string obtained using JSON.stringify() will be different and the method will return false, whereas it should return true.

The fix uses deep-equal module to avoid this bug.

I have although added a unit test to test the solution (in streaming.utils.ObjectUtils.js file) : using JSON.stringify(), the unit test fails, using deep-equal module, the test is in success

[davemevans]

This isn't a bug - the whole point of this method was to avoid importing a module and simply compare objects constructed in a predictable manner - see the jsdoc above. With this PR the method has no value now so the whole objectutils could be removed and deep-equal imported where needed.

[dsparacio]

Guys is this needed or not. If not please close or please merge.

[jeremco]

Hi guys

From my point of view, if you are planning to release an industrial product, I think we should correct this potential bug (even if the code is predictable).
Moreover, I think keeping objectUtils has a meaning : for one ore more reasons (performances of used module, bug in module ...), it is more easy to replace one external module in one file, rather than in several files. Doing this, you decrease the risk of regressions.

It's up to you to merge or not.

[davemevans]

I still think it'd be better to change the method name, or have an additional method for deep compare, (areEquivalent?), but I don't feel that strongly.

[jeremco]

I have renamed ObjectUtils::areSimpleEquivalent as ObjectUtils::areEqual to avoid any confusion

[davemevans]

LGTM.