Add string constants file #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davemevans
reviewed
Jun 7, 2017
|
|
||
| class StringMatcher extends BaseMatcher { | ||
| constructor() { | ||
| super( | ||
| (attr, nodeName) => { | ||
| const stringAttrsInElements = { | ||
| 'MPD': [ 'id', 'profiles' ], | ||
| 'Period': [ 'id' ], |
There was a problem hiding this comment.
In ES6, these keys can also be replaced with DashConstant constants by wrapping them in [ ]. See https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/XHRLoader.js#L63 for an example.
There was a problem hiding this comment.
Meant to comment on the addition rather than the removal but you get the idea ...
There was a problem hiding this comment.
Thanks @bbcrddave for the tip, I didn't know it was possible.
I have made the modification
jeremco
force-pushed
the
add_constants_file
branch
2 times, most recently
from
f69c546
to
96e80ef
Compare
jeremco
force-pushed
the
add_constants_file
branch
4 times, most recently
from
f910a40
to
38960fe
Compare
…imum allowed is 30. '
jeremco
force-pushed
the
add_constants_file
branch
from
38960fe
to
1b5eb92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
The goal of this PR is to remove hardcoded strings, and to add constants files.
I have added 3 constants files :
The idea is to centralized strings constants, so that they can be easily used and of course modified if needed.
Jérémie