New refactoring branch #2140
Merged
New refactoring branch #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
newRefactoringBranch
branch
from
d16ac45
to
708f086
Compare
nicosang
force-pushed
the
newRefactoringBranch
branch
4 times, most recently
from
83a2564
to
b85802b
Compare
|
@nicosang, many thanks, this looks fine to me. A conflict appeared after the latest merges but once resolve, this is ready to be merged. |
remove initialize function
…ed to destroy those objects. objects set by setConfig function are not created by the class, no need to destroy those objects.
…vents function in the setup function
…omm/3/Solekai.mpd, period id = " " update test on id definition....
nicosang
force-pushed
the
newRefactoringBranch
branch
from
83bc149
to
7f0f792
Compare
|
@epiclabsDASH , it should be good now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.