Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSS] Fix representation's width and height #3539

Conversation

bbert
Copy link
Contributor

@bbert bbert commented Feb 17, 2021

This PR is fixing MSS parser for representations width and height.
The MSS parser was previously setting these values to NaN if not signaled in manifest (for non-video tracks).

@bbert bbert added Bug MSS Microsoft Smooth Streaming labels Feb 17, 2021
@dsilhavy dsilhavy added this to the 3.2.1 milestone Feb 17, 2021
@dsilhavy dsilhavy self-requested a review February 17, 2021 18:04
@dsilhavy dsilhavy merged commit 9cadfc2 into Dash-Industry-Forum:development Feb 18, 2021
@bbert bbert deleted the fix-mss-width-height branch February 19, 2021 14:44
bbert added a commit to Orange-OpenSource/dash.js that referenced this pull request Mar 4, 2021
* MSS parser: set representation width and height only if available

* MSS parser: fix qualities id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug MSS Microsoft Smooth Streaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants