-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor text tracks #3641
Merged
dsilhavy
merged 17 commits into
Dash-Industry-Forum:development
from
Orange-OpenSource:feat-text-tracks
Jun 11, 2021
Merged
Refactor text tracks #3641
dsilhavy
merged 17 commits into
Dash-Industry-Forum:development
from
Orange-OpenSource:feat-text-tracks
Jun 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mple fragmented vtt): - use segment info/template from manifest to determine if track is fragmented or not (do not rely on codecs property) - use TextSourceBuffer also for "vtt" codec - do not request for init segments if none
- keep only type "text" for all text tracks - rely on TextTrackInfo.isFragmented and isEmbedded to get type of text tracks - unify text tracks metadata returned by MediaPlayer.getTracksFor() and in TEXT_TRACKS_ADDED event (TextTrackInfo extends MediaInfo) - rely on segments templates to know if a text track is fragmented or not
dsilhavy
reviewed
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors text tracks managements in order to:
As a benefit: