Fix: handle Emulation Prevention Bytes in CEA-608 parsing #3719
Conversation
grabofus
changed the title
There was a problem hiding this comment.
This code is copied from the DASH-IF cea608.js repo, so it should rather be a PR towards that repo, and then it should be updated here by including an updated version.
I haven't looked at that repo for a long time, but I just did, so I'll look at this at this as well, once it's sent there.
Removing start code emulation preventions bytes is apparently a lacking feature in cea608.js so it is a good thing to get that fixed.
|
@dsilhavy I made a ticket in cea608.js to make a proper NPM package so that the code can be imported in a better way. |
|
Thank you @tobbee . |
|
@littlespex Do you know if this fix will be included in the CEA-608 implementation of the CML? |
|
We will add this along with the Dash-Industry-Forum/cea608.js#3 |
Ported over changes from Dash-Industry-Forum/dash.js#3719
Ported over changes from Dash-Industry-Forum/dash.js#3719 Signed-off-by: Agajan Jumakuliyev <agajan.tm@gmail.com>
Switching to Cta608Parser from common-media-library. Also includes changes that fixes emulation prevention bytes in cea-608 parsing. See Dash-Industry-Forum#3719
* Delete cea608-parser.js Deleted this since we are now using Cta608Parser from common-media-library instead * Update MediaPlayer.js setting Cta608Parser from comon-media-library for adapter to use * Update TextSourceBuffer.js Switching to Cta608Parser from common-media-library. Also includes changes that fixes emulation prevention bytes in cea-608 parsing. See #3719 * Update package.json new dependency for common-media-library version 0.7.0 * Update package-lock.json * Update dash.DashAdapter.js correcting unit test for the parser * Update package.json * Update package-lock.json * Update package.json * Update package-lock.json * Update webpack.config.js Configured polyfill for timers to resolve build issues related to xml2js dependency * Update webpack.config.js * Update package.json * Update package-lock.json * Update package.json * Update package-lock.json * fix: missing karam dep --------- Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
|
This was addressed in #4522 . Thanks for the PR, closing this. |
Addresses #3679