Prevent redundant CC parser restarts during Low Latency streams #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-buczek Thanks for your PR. Following our contribution guidelines, and since this seems to be your first PR, could you please send me a signed copy of dash.js feedback agreement? Note: If your company is a DASH-IF member you dont need to sign the CLA, contributions are covered by the DASH-IF membership. |
|
@dsilhavy Hey, I sent you the required document by e-mail. |
|
Unfortunately I don't have the ability to provide a stream for testing. The streams (of our clients) on which I tested the fix are DRM encrypted, additionally, geolocation blocks are used. |
eirikbjornr
pushed a commit
to bbc/dash.js
that referenced
this pull request
Feb 14, 2024
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, in low latency streams, the sequence number is always set to 1, leading to redundant restarts of embeddedCea608FieldParsers. Consequently, most subtitles are not displayed as expected.
Proposed Solution:
To address this issue, I suggest implementing a check for the continuity of the chunks when the sequence number is always 1. By ensuring the proper continuity of the chunks, we can avoid unnecessary parser restarts and ensure the correct display of subtitles during low latency streams.
The solution is tested and works in production on many LL channels.