add setting to change mediasource duration from infinity to math.pow(2, 32) #4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsilhavy
requested changes
Sep 5, 2023
bwallberg
force-pushed
the
feat/mediaSourceDurationInfinity
branch
from
65fbeb0
to
ded06e6
Compare
eirikbjornr
pushed a commit
to bbc/dash.js
that referenced
this pull request
Feb 14, 2024
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on slack https://dashif.slack.com/archives/C11R69M96/p1693394978870319
On WebOS 4.x ( Chrome 53 ) seeking in live content is currently broken because when duration is Infinity seeking back in time causes the seekable end time to move to the seek point so once you’ve seeked back in time you can never go to live again.
The solution is to set the duration of the MediaSource to something high so that you’re not blocked from appending segments eg. Math.pow(2, 32); eg. like shaka https://github.com/shaka-project/shaka-player/blob/main/lib/media/streaming_engine.js#L922