fix skip flow when actualurl is an empty string #4328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whoisurdaddyninja567 Thanks for your PR. Following our contribution guidelines, and since this seems to be your first PR, could you please send me a signed copy of dash.js feedback agreement? Note: If your company is a DASH-IF member or did sign the CLA before you dont need to sign the CLA. |
|
@whoisurdaddyninja567 Did you have the chance to sign the feedback agreement? |
|
Sorry, I'm not ready to sign the feedback agreement. |
If you cant sign the FA any time soon I can also offer to close the PR and apply a fix myself. |
|
As the FA can not be signed at this point I am closing this PR and adding the required check here in #4368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Test case is from hbbtv.org, which is the HBBTV official site. This case is expect to report a C01 error to the hbbtv test server, but gets none.
First tips
I found out the reason is that atucalurl is an empty string.
If using the old expresseion:
if (actualurl && (actualurl !== url)), it will return false and skip the statements in the curly brace. It needs to change to the new expression:if (actualurl !== null && actualurl !== undefined && (actualurl !== url)).Second tips
The testcase supposes to get the report with serviceLocation, so I append it.
Please have a look, check & verify this Pull Request. Thank you!