Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temperature detection and reporting improvements #341

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Temperature detection and reporting improvements #341

merged 1 commit into from
Jul 22, 2024
+46 −10

Conversation

tym2k1
Copy link
Contributor

@tym2k1 tym2k1 commented Jul 1, 2024

Fixes for #281

@tym2k1 tym2k1 force-pushed the cpu_tmp_read_improvements branch from 32d354b to 038c0b5 Compare July 1, 2024 15:09
@tym2k1 tym2k1 linked an issue Jul 1, 2024 that may be closed by this pull request
Temperature detection and reporting should be reworked #281
Closed
@tym2k1 tym2k1 marked this pull request as draft July 1, 2024 15:59
@tym2k1
Copy link
Contributor Author

tym2k1 commented Jul 1, 2024

It would also be cool to graph the CPU temperature instead of printing the raw numbers. Tools like termgraph or matplotlib can be used here. TBD

@wiktormowinski wiktormowinski deleted the branch develop July 2, 2024 12:10
@wiktormowinski wiktormowinski reopened this Jul 3, 2024
@tym2k1 tym2k1 force-pushed the cpu_tmp_read_improvements branch from 038c0b5 to 384a1a1 Compare July 9, 2024 16:10
@tym2k1 tym2k1 marked this pull request as ready for review July 9, 2024 16:17
@tym2k1 tym2k1 requested a review from macpijan July 9, 2024 16:17
@tym2k1
Copy link
Contributor Author

tym2k1 commented Jul 9, 2024

Ready for review. I've created an issue related to graphing the CPU temperature for it to be handled at a later time.

@tym2k1 tym2k1 force-pushed the cpu_tmp_read_improvements branch from 384a1a1 to e146446 Compare July 10, 2024 12:32
@tym2k1
Copy link
Contributor Author

tym2k1 commented Jul 10, 2024

While rebasing on top of develop i've noticed that the functionality has been already added some time ago. Thus I only retained the logging improvements so console isn't flooded with log messages every second

@tym2k1 tym2k1 force-pushed the cpu_tmp_read_improvements branch 2 times, most recently from 1acd7f7 to 4da24c4 Compare July 10, 2024 12:40
@macpijan macpijan mentioned this pull request Jul 16, 2024
Open
@tym2k1 @macpijan
dasharo-performance/cpu-temperature.robot: improved logging
99dc95c 
Signed-off-by: Tymoteusz Burak <tymoteusz.burak@3mdeb.com>
@macpijan macpijan force-pushed the cpu_tmp_read_improvements branch from 4da24c4 to 99dc95c Compare July 22, 2024 22:04
@macpijan macpijan merged commit 99dc95c into develop Jul 22, 2024
@macpijan macpijan deleted the cpu_tmp_read_improvements branch July 22, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macpijan macpijan macpijan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temperature detection and reporting should be reworked
3 participants
@tym2k1 @macpijan @wiktormowinski