Skip to content

Remove clang-format check via GitHub Action #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 17, 2024
Merged

Remove clang-format check via GitHub Action #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e03d24b
Bump clang-format version
IshaanDesai Oct 17, 2024
2cf2a49
Formatting
IshaanDesai Oct 17, 2024
36943af
Use a different Action workflow to run clang-format
IshaanDesai Oct 17, 2024
4f6834f
Remove the Action to run clang-format, as it will go out of sync with…
IshaanDesai Oct 17, 2024
c1bf68b
Bump mirror-clang-format to latest version in the pre-commit-config
IshaanDesai Oct 17, 2024
c082c81
Update clang-format config file to also format JSON
IshaanDesai Oct 17, 2024
64edabf
Manually specify which extensions to format in the mirror-clang-forma…
IshaanDesai Oct 17, 2024
109796f
Exclude JSON files from clang-format
IshaanDesai Oct 17, 2024
0c25e56
Exclude JSON files from clang-format
IshaanDesai Oct 17, 2024
3873d36
Correctly exclude JSON files from clang-format checking
IshaanDesai Oct 17, 2024
694912d
Rather than excluding json, specifically suggest c++
IshaanDesai Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .github/workflows/clang-format-check.yml
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ repos:
- id: black
# clang-format for C/C++ formatting
- repo: https://github.com/pre-commit/mirrors-clang-format
rev: v8.0.1
rev: v19.1.2
hooks:
- id: clang-format
args: ['--style=file']
exclude: "include/json.hpp"
types_or: [c++]
2 changes: 1 addition & 1 deletion include/general.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,4 @@ inline V *FANS_malloc(size_t n)

#define VERBOSITY 0

//#define EIGEN_RUNTIME_NO_MALLOC
// #define EIGEN_RUNTIME_NO_MALLOC
2 changes: 1 addition & 1 deletion include/solver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class Solver {
void iterateCubes(F f);

void solve();
virtual void internalSolve(){}; // important to have "{}" here, otherwise we get an error about undefined reference to vtable
virtual void internalSolve() {}; // important to have "{}" here, otherwise we get an error about undefined reference to vtable

template <int padding, typename F>
void compute_residual_basic(RealArray &r_matrix, RealArray &u_matrix, F f);
Expand Down