Skip to content

Conversation

sethfowler-datadog
Copy link
Contributor

Motivation

The should not collect recorder init metrics telemetry when telemetry is disabled test in startRecorderInitTelemetry.spec.ts was identified as flaky; we should fix this.

Changes

This test is intended to:

  1. Set the recorder init metrics telemetry sample rate to zero.
  2. Do some things that would generate recorder init metrics telemetry.
  3. Verify that no telemetry was actually generated.

It had a bug in step one; it used the wrong configuration option to set the sample rate to zero. Because the wrong option was used, the sample rate was actually 1%, causing the test to flake at about that rate.

This PR fixes the issues by updating the test to use the correct configuration option.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@sethfowler-datadog sethfowler-datadog requested a review from a team as a code owner September 17, 2025 14:13
@sethfowler-datadog sethfowler-datadog force-pushed the seth.fowler/PANA-4236-fix-flaky-recorder-init-telemetry-test branch from a01c627 to aedeef1 Compare September 18, 2025 09:12
@datadog-datadog-prod-us1
Copy link

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.50% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: aedeef1 | Docs | Was this helpful? Give us feedback!

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum N/A 160.90 KiB 160.90 KiB N/A%
Rum Recorder N/A 19.53 KiB 19.53 KiB N/A%
Rum Profiler N/A 5.32 KiB 5.32 KiB N/A%
Logs N/A 55.82 KiB 55.82 KiB N/A%
Flagging N/A 931 B 931 B N/A%
Rum Slim N/A 118.55 KiB 118.55 KiB N/A%
Worker N/A 23.60 KiB 23.60 KiB N/A%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext N/A N/A N/A
addaction 0.018 0.017 -0.001
addtiming N/A N/A N/A
adderror N/A N/A N/A
startstopsessionreplayrecording N/A N/A N/A
startview N/A N/A N/A
logmessage N/A N/A N/A
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext N/A 25.88 KiB N/A
addaction N/A 47.18 KiB N/A
addtiming N/A 24.54 KiB N/A
adderror N/A 51.46 KiB N/A
startstopsessionreplayrecording N/A 24.14 KiB N/A
startview N/A 430.17 KiB N/A
logmessage N/A 42.67 KiB N/A

🔗 RealWorld

@sethfowler-datadog
Copy link
Contributor Author

/to-staging

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 18, 2025

View all feedbacks in Devflow UI.

2025-09-18 09:50:21 UTC ℹ️ Start processing command /to-staging


2025-09-18 09:50:28 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 11m (p90)

Commit aedeef16b6 will soon be integrated into staging-38.


2025-09-18 09:50:41 UTC 🚨 Branch Integration: this merge request has conflicts which couldn't be solved automatically

We couldn't automatically merge the commit aedeef16b6 into staging-38!

To solve the conflicts directly in Github, click here to create a fix pull request.

Alternatively, you can also click here reset the integration branch or use the following Slack command: /devflow reset-branch -r browser-sdk -b staging-38

dd-devflow bot added a commit that referenced this pull request Sep 18, 2025
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Sep 18, 2025

🚂 Branch Integration: starting soon, merge expected in approximately 11m (p90)

Commit aedeef16b6 will soon be integrated into staging-38.

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Sep 18, 2025

🚂 Branch Integration

Commit aedeef16b6 has been merged into staging-38 in merge commit cc900eebe7.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-38

@sethfowler-datadog sethfowler-datadog merged commit 792dec2 into main Sep 18, 2025
22 checks passed
@sethfowler-datadog sethfowler-datadog deleted the seth.fowler/PANA-4236-fix-flaky-recorder-init-telemetry-test branch September 18, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants