-
Notifications
You must be signed in to change notification settings - Fork 162
🐛 [PANA-4236] Fix flaky startRecorderInitTelemetry test #3852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [PANA-4236] Fix flaky startRecorderInitTelemetry test #3852
Conversation
a01c627
to
aedeef1
Compare
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: aedeef1 | Docs | Was this helpful? Give us feedback! |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
/to-staging |
View all feedbacks in Devflow UI.
Commit aedeef16b6 will soon be integrated into staging-38.
We couldn't automatically merge the commit aedeef16b6 into staging-38! To solve the conflicts directly in Github, click here to create a fix pull request. Alternatively, you can also click here reset the integration branch or use the following Slack command: |
🚂 Branch Integration: starting soon, merge expected in approximately 11m (p90) Commit aedeef16b6 will soon be integrated into staging-38. |
🚂 Branch Integration Commit aedeef16b6 has been merged into staging-38 in merge commit cc900eebe7. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
Motivation
The
should not collect recorder init metrics telemetry when telemetry is disabled
test instartRecorderInitTelemetry.spec.ts
was identified as flaky; we should fix this.Changes
This test is intended to:
It had a bug in step one; it used the wrong configuration option to set the sample rate to zero. Because the wrong option was used, the sample rate was actually 1%, causing the test to flake at about that rate.
This PR fixes the issues by updating the test to use the correct configuration option.
Checklist