Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to docker compose v2 in integration tests #25465

Merged
merged 13 commits into from
May 9, 2024

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented May 8, 2024

What does this PR do?

Motivation

#incident-27281

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 8, 2024

[Fast Unit Tests Report]

On pipeline 33951050 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@spencergilbert spencergilbert force-pushed the paulcacheux/fix-integration-tests branch from 628e26b to fb6640a Compare May 8, 2024 15:02
@pr-commenter
Copy link

pr-commenter bot commented May 8, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=33951050 --os-family=ubuntu

test/integration/utils/compose.go Outdated Show resolved Hide resolved
test/integration/utils/compose.go Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented May 8, 2024

Regression Detector

Regression Detector Results

Run ID: a739331a-293c-4922-8160-c2587a413ed1
Baseline: afdb477
Comparison: e54835d

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +6.76 [-0.70, +14.21]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +6.76 [-0.70, +14.21]
pycheck_1000_100byte_tags % cpu utilization +1.41 [-3.34, +6.15]
uds_dogstatsd_to_api_cpu % cpu utilization +0.69 [-2.22, +3.59]
file_tree memory utilization +0.28 [+0.18, +0.37]
basic_py_check % cpu utilization +0.19 [-2.26, +2.64]
otel_to_otel_logs ingress throughput +0.12 [-0.24, +0.48]
process_agent_standard_check_with_stats memory utilization +0.06 [+0.00, +0.11]
trace_agent_msgpack ingress throughput +0.01 [+0.00, +0.02]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.03, +0.01]
idle memory utilization -0.03 [-0.07, +0.00]
process_agent_standard_check memory utilization -0.05 [-0.11, +0.01]
process_agent_real_time_mode memory utilization -0.41 [-0.45, -0.37]
tcp_syslog_to_blackhole ingress throughput -0.81 [-21.72, +20.11]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@sblumenthal sblumenthal added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels May 9, 2024
@sblumenthal sblumenthal added this to the 7.54.0 milestone May 9, 2024
@sblumenthal sblumenthal marked this pull request as ready for review May 9, 2024 14:31
@sblumenthal sblumenthal requested review from a team as code owners May 9, 2024 14:31
@ofek
Copy link
Contributor

ofek commented May 9, 2024

Can we use Docker directly? See:

❯ docker run --rm docker:26.1-cli /usr/local/bin/docker compose version
Docker Compose version v2.27.0

@spencergilbert
Copy link
Contributor

Can we use Docker directly? See:

❯ docker run --rm docker:26.1-cli /usr/local/bin/docker compose version
Docker Compose version v2.27.0

That had failed to work at some point in testing yesterday, we could revisit though.

@ofek
Copy link
Contributor

ofek commented May 9, 2024

Do you recall what didn't work?

@spencergilbert
Copy link
Contributor

Do you recall what didn't work?

IIRC those are alpine based, and there were issues with cgo?

@ofek
Copy link
Contributor

ofek commented May 9, 2024

Oh, perhaps I misread, are we not invoking the binaries as a subprocess?

@sblumenthal
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 9, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented May 9, 2024

⚠️ MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 9, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 54m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 6d305d8 into main May 9, 2024
211 of 212 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/fix-integration-tests branch May 9, 2024 21:01
agent-platform-auto-pr bot pushed a commit that referenced this pull request May 9, 2024
Co-authored-by: sblumenthal <steven.blumenthal@datadoghq.com>
Co-authored-by: spencergilbert <spencer.gilbert@datadoghq.com>
(cherry picked from commit 6d305d8)
dd-mergequeue bot pushed a commit that referenced this pull request May 10, 2024
Co-authored-by: paulcacheux <paul.cacheux@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.54.x changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/agent-ci-experience team/agent-developer-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants