Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OASIS-12] Set APM configs in OTel agent #26625

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Jun 11, 2024

What does this PR do?

  1. Set APM configs in OTel agent
  2. Add a missing config compute_top_level_by_span_kind
  3. Remove several unused configs in exporter
  4. Enable span_name_as_resource_name and compute_top_level_by_span_kind by default

Motivation

Split from #25759. These are used to configured trace agent comp.

@songy23 songy23 added changelog/no-changelog team/opentelemetry OpenTelemetry team qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Jun 11, 2024
@songy23 songy23 added this to the 7.56.0 milestone Jun 11, 2024
@songy23 songy23 requested a review from dineshg13 June 11, 2024 20:33
@songy23 songy23 marked this pull request as ready for review June 11, 2024 20:33
@songy23 songy23 requested a review from a team as a code owner June 11, 2024 20:33
@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=36587059 --os-family=ubuntu

Note: This applies to commit 561305b

@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2024

Regression Detector

Regression Detector Results

Run ID: 955ad720-1375-4499-8bcf-5e302e933e39
Baseline: 20a6011
Comparison: 561305b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +4.54 [-0.26, +9.35]
file_tree memory utilization +0.39 [+0.30, +0.47]
idle memory utilization +0.11 [+0.08, +0.15]
basic_py_check % cpu utilization +0.09 [-3.00, +3.18]
otel_to_otel_logs ingress throughput +0.06 [-0.30, +0.42]
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.05]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput -0.02 [-0.22, +0.19]
uds_dogstatsd_to_api_cpu % cpu utilization -0.56 [-3.44, +2.31]
tcp_syslog_to_blackhole ingress throughput -9.25 [-29.20, +10.70]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

cmd/otel-agent/config/agent_config.go Outdated Show resolved Hide resolved
pkgconfig.Set("apm_config.enabled", true, pkgconfigmodel.SourceLocalConfigProcess)
pkgconfig.Set("apm_config.apm_non_local_traffic", true, pkgconfigmodel.SourceLocalConfigProcess)
pkgconfig.Set("otlp_config.traces.span_name_as_resource_name", ddc.Traces.SpanNameAsResourceName, pkgconfigmodel.SourceLocalConfigProcess)
Copy link
Member

@dineshg13 dineshg13 Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same. Please set this to true by default

Copy link
Member Author

@songy23 songy23 Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we cannot do it until the OSS datadog connector sets this to true. Right now this is false by default in datadog connector. If here it is set to true, the operation names in spans vs. in APM stats will be different by default and that leads to mismatch or missing spans on the UI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted offline, I flipped compute_top_level_by_span_kind and span_name_as_resource_name to true by default.

We need to make sure the datadog connector has the same default in OTel agent (via config converter?). cc @mackjmr

@songy23 songy23 requested a review from dineshg13 June 12, 2024 20:25
@songy23
Copy link
Member Author

songy23 commented Jun 13, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 29m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 5e2ac69 into main Jun 13, 2024
215 of 217 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yang.song/otel-trace-exp branch June 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants