-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OASIS-12] Set APM configs in OTel agent #26625
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=36587059 --os-family=ubuntu Note: This applies to commit 561305b |
Regression DetectorRegression Detector ResultsRun ID: 955ad720-1375-4499-8bcf-5e302e933e39 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | pycheck_1000_100byte_tags | % cpu utilization | +4.54 | [-0.26, +9.35] |
➖ | file_tree | memory utilization | +0.39 | [+0.30, +0.47] |
➖ | idle | memory utilization | +0.11 | [+0.08, +0.15] |
➖ | basic_py_check | % cpu utilization | +0.09 | [-3.00, +3.18] |
➖ | otel_to_otel_logs | ingress throughput | +0.06 | [-0.30, +0.42] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.02, +0.05] |
➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | trace_agent_json | ingress throughput | +0.00 | [-0.01, +0.01] |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.22, +0.19] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.56 | [-3.44, +2.31] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -9.25 | [-29.20, +10.70] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
pkgconfig.Set("apm_config.enabled", true, pkgconfigmodel.SourceLocalConfigProcess) | ||
pkgconfig.Set("apm_config.apm_non_local_traffic", true, pkgconfigmodel.SourceLocalConfigProcess) | ||
pkgconfig.Set("otlp_config.traces.span_name_as_resource_name", ddc.Traces.SpanNameAsResourceName, pkgconfigmodel.SourceLocalConfigProcess) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same. Please set this to true by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we cannot do it until the OSS datadog connector sets this to true. Right now this is false by default in datadog connector. If here it is set to true, the operation names in spans vs. in APM stats will be different by default and that leads to mismatch or missing spans on the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted offline, I flipped compute_top_level_by_span_kind and span_name_as_resource_name to true by default.
We need to make sure the datadog connector has the same default in OTel agent (via config converter?). cc @mackjmr
af1506c
to
561305b
Compare
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
compute_top_level_by_span_kind
span_name_as_resource_name
andcompute_top_level_by_span_kind
by defaultMotivation
Split from #25759. These are used to configured trace agent comp.