-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/trace/api: enable Windows pipe support #6615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogaca-dd
reviewed
Oct 27, 2020
Windows pipes are now supported by means of: * `DD_APM_WINDOWS_PIPE_NAME` defines the pipe name to be used. * `DD_APM_WINDOWS_PIPE_BUFFER_SIZE` defines the input buffer size (defaults to 1MB).
knusbaum
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
gbbr
added a commit
that referenced
this pull request
Dec 2, 2020
Windows pipes are now supported by means of: * `DD_APM_WINDOWS_PIPE_NAME` defines the pipe name to be used. * `DD_APM_WINDOWS_PIPE_BUFFER_SIZE` defines the input buffer size (defaults to 1MB). * `DD_APM_WINDOWS_PIPE_SECURITY_DESCRIPTOR` allows setting the security ID. Defaults to `D:AI(A;;GA;;;WD)` (grants access to everyone)
sergei-deliveroo
pushed a commit
to deliveroo/datadog-agent
that referenced
this pull request
Mar 24, 2021
Windows pipes are now supported by means of: * `DD_APM_WINDOWS_PIPE_NAME` defines the pipe name to be used. * `DD_APM_WINDOWS_PIPE_BUFFER_SIZE` defines the input buffer size (defaults to 1MB). * `DD_APM_WINDOWS_PIPE_SECURITY_DESCRIPTOR` allows setting the security ID. Defaults to `D:AI(A;;GA;;;WD)` (grants access to everyone)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows pipes are now supported by means of:
DD_APM_WINDOWS_PIPE_NAME
defines the pipe name to be used.DD_APM_WINDOWS_PIPE_BUFFER_SIZE
defines the input buffer size(defaults to 1MB).
DD_APM_WINDOWS_PIPE_SECURITY_DESCRIPTOR
allows setting the security ID. Defaults toD:AI(A;;GA;;;WD)
(grants access to everyone)