Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/trace/api: enable Windows pipe support #6615

Merged
merged 3 commits into from
Dec 2, 2020
Merged

pkg/trace/api: enable Windows pipe support #6615

merged 3 commits into from
Dec 2, 2020

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Oct 22, 2020

Windows pipes are now supported by means of:

  • DD_APM_WINDOWS_PIPE_NAME defines the pipe name to be used.
  • DD_APM_WINDOWS_PIPE_BUFFER_SIZE defines the input buffer size
    (defaults to 1MB).
  • DD_APM_WINDOWS_PIPE_SECURITY_DESCRIPTOR allows setting the security ID. Defaults to D:AI(A;;GA;;;WD) (grants access to everyone)

@gbbr gbbr added the team/agent-apm trace-agent label Oct 22, 2020
@gbbr gbbr added this to the 7.24.0 milestone Oct 22, 2020
@gbbr gbbr requested review from a team as code owners October 22, 2020 12:42
@gbbr gbbr modified the milestones: 7.24.0, Triage Oct 29, 2020
Windows pipes are now supported by means of:

* `DD_APM_WINDOWS_PIPE_NAME` defines the pipe name to be used.
* `DD_APM_WINDOWS_PIPE_BUFFER_SIZE` defines the input buffer size
  (defaults to 1MB).
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@knusbaum knusbaum modified the milestones: Triage, 7.25.0 Dec 1, 2020
@gbbr gbbr merged commit 09f051a into master Dec 2, 2020
@gbbr gbbr deleted the gbbr/win-pipe branch December 2, 2020 08:13
gbbr added a commit that referenced this pull request Dec 2, 2020
Windows pipes are now supported by means of:

* `DD_APM_WINDOWS_PIPE_NAME` defines the pipe name to be used.
* `DD_APM_WINDOWS_PIPE_BUFFER_SIZE` defines the input buffer size
  (defaults to 1MB).
* `DD_APM_WINDOWS_PIPE_SECURITY_DESCRIPTOR` allows setting the security ID. Defaults to `D:AI(A;;GA;;;WD)` (grants access to everyone)
sergei-deliveroo pushed a commit to deliveroo/datadog-agent that referenced this pull request Mar 24, 2021
Windows pipes are now supported by means of:

* `DD_APM_WINDOWS_PIPE_NAME` defines the pipe name to be used.
* `DD_APM_WINDOWS_PIPE_BUFFER_SIZE` defines the input buffer size
  (defaults to 1MB).
* `DD_APM_WINDOWS_PIPE_SECURITY_DESCRIPTOR` allows setting the security ID. Defaults to `D:AI(A;;GA;;;WD)` (grants access to everyone)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants