Skip to content

Conversation

nhulston
Copy link
Contributor

What does this PR do?

When creating the kmsClient, set useFipsEndpoint to true if in a govcloud region.

Motivation

Making our products FIPs compliant.

Testing Guidelines

Manually. Works in both Govcloud and commercial regions.

Additional Notes

Related PR: #634

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@nhulston nhulston requested a review from a team as a code owner March 11, 2025 15:18
@nhulston nhulston requested a review from duncanista March 11, 2025 15:43
@nhulston nhulston merged commit 579407e into main Mar 12, 2025
25 checks passed
@nhulston nhulston deleted the nicholas.hulston/use-fips-endpoint-in-kms branch March 12, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants