Skip to content

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented May 18, 2023

What does this PR do?

  • When neither x-ray nor dd-trace is used, the tracing context should be {} and set_correlation_ids() should not break. That is ,
if not context:
    return
  • Reorganized the code for get_dd_trace_context but no logic change.

Motivation

#332

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner May 18, 2023 13:28
@joeyzhao2018 joeyzhao2018 changed the title Joey/set correlation ids set_correlation_ids should handle the empty context case May 18, 2023
@joeyzhao2018 joeyzhao2018 force-pushed the joey/set-correlation-ids branch from 656432f to b842186 Compare May 18, 2023 20:26
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joeyzhao2018 joeyzhao2018 merged commit 77ade82 into main May 23, 2023
@joeyzhao2018 joeyzhao2018 deleted the joey/set-correlation-ids branch May 23, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants