Skip to content

fix(profiling): include ddup and dd_wrapper so files to enable profiling #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Jul 24, 2025

What does this PR do?

Since dd-trace-py 3.10.0, libdatadog exporter is needed to use profiling. Include necessary .so files that have previously been removed.

Also increases layer size limits from 6 -> 8 (compressed), and 15 to 21 KBs (uncompressed)

Motivation

Layer file .layers/datadog_lambda_py-amd64-3.10.zip has zipped size 7467 kb
Layer file .layers/datadog_lambda_py-amd64-3.10.zip has unzipped size 17627 kb

Layer file .layers/datadog_lambda_py-arm64-3.10.zip has zipped size 7173 kb
Layer file .layers/datadog_lambda_py-arm64-3.10.zip has unzipped size 16898 kb

Layer file .layers/datadog_lambda_py-amd64-3.11.zip has zipped size 7833 kb
Layer file .layers/datadog_lambda_py-amd64-3.11.zip has unzipped size 20493 kb

Layer file .layers/datadog_lambda_py-arm64-3.11.zip has zipped size 7538 kb
Layer file .layers/datadog_lambda_py-arm64-3.11.zip has unzipped size 19808 kb

Layer file .layers/datadog_lambda_py-amd64-3.12.zip has zipped size 7809 kb
Layer file .layers/datadog_lambda_py-amd64-3.12.zip has unzipped size 20053 kb

Layer file .layers/datadog_lambda_py-arm64-3.12.zip has zipped size 7511 kb
Layer file .layers/datadog_lambda_py-arm64-3.12.zip has unzipped size 19286 kb

Layer file .layers/datadog_lambda_py-amd64-3.13.zip has zipped size 7866 kb
Layer file .layers/datadog_lambda_py-amd64-3.13.zip has unzipped size 20195 kb

Layer file .layers/datadog_lambda_py-arm64-3.13.zip has zipped size 7571 kb
Layer file .layers/datadog_lambda_py-arm64-3.13.zip has unzipped size 19502 kb

Layer file .layers/datadog_lambda_py-amd64-3.8.zip has zipped size 7441 kb
Layer file .layers/datadog_lambda_py-amd64-3.8.zip has unzipped size 17646 kb

Layer file .layers/datadog_lambda_py-arm64-3.8.zip has zipped size 7144 kb
Layer file .layers/datadog_lambda_py-arm64-3.8.zip has unzipped size 16894 kb

Layer file .layers/datadog_lambda_py-amd64-3.9.zip has zipped size 7431 kb
Layer file .layers/datadog_lambda_py-amd64-3.9.zip has unzipped size 17598 kb

Layer file .layers/datadog_lambda_py-arm64-3.9.zip has zipped size 7135 kb
Layer file .layers/datadog_lambda_py-arm64-3.9.zip has unzipped size 16909 kb

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@taegyunkim taegyunkim requested review from a team as code owners July 24, 2025 16:08
@taegyunkim taegyunkim changed the title chore(profiling): include ddup and dd_wrapper so files fix(profiling): include ddup and dd_wrapper so files Jul 24, 2025
@taegyunkim taegyunkim changed the title fix(profiling): include ddup and dd_wrapper so files fix(profiling): include ddup and dd_wrapper so files to enable profiling Jul 24, 2025
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from Serverless, I'd wait for someone from APM Serverless to approve too!

@taegyunkim taegyunkim merged commit 502303d into main Jul 24, 2025
61 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/include-dd branch July 24, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants