Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak caused by repeated calls to WeakReference.get() #1763

Closed
wants to merge 12 commits into from

Conversation

pyricau
Copy link
Contributor

@pyricau pyricau commented Dec 14, 2023

If the view is already stopped, there's no need to determine whether it needs to be stopped.

See #1762

Copy link
Member

@mariusc83 mariusc83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tks for taking the time for this fix.

@xgouchet xgouchet changed the base branch from master to develop December 18, 2023 14:09
@xgouchet
Copy link
Member

Thanks a lot for your contribution @pyricau

in order for us to merge this PR, we need have two requirements to be met:

@0xnm
Copy link
Member

0xnm commented Dec 20, 2023

Hello @pyricau! We have merged your commit in #1779, thanks a lot for your contribution.

@0xnm 0xnm closed this Dec 20, 2023
@xgouchet xgouchet added this to the Dropped milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants