Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak caused by repeated calls to WeakReference.get() #1779

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Dec 20, 2023

Port of commit from #1763 in our repo, to be able to run all the checks.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

If the view is already stopped, there's no need to determine whether it needs to be stopped.

See #1762
@0xnm 0xnm requested review from a team as code owners December 20, 2023 11:02
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Merging #1779 (75bb88a) into develop (c048dcd) will increase coverage by 0.05%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1779      +/-   ##
===========================================
+ Coverage    83.36%   83.41%   +0.05%     
===========================================
  Files          465      465              
  Lines        16348    16349       +1     
  Branches      2456     2457       +1     
===========================================
+ Hits         13627    13636       +9     
+ Misses        2047     2039       -8     
  Partials       674      674              
Files Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 93.94% <100.00%> (-0.15%) ⬇️

... and 18 files with indirect coverage changes

@0xnm 0xnm merged commit 04ff060 into develop Dec 20, 2023
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/fix-key-reference-leak branch December 20, 2023 11:33
@xgouchet xgouchet added this to the 2.4.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants