Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/net/http: Add new option to RoundTripper to ignore outgoing request #1403

Merged
merged 5 commits into from
Aug 1, 2022

Conversation

dianashevchenko
Copy link
Contributor

Closes #1398

@dianashevchenko dianashevchenko requested a review from a team July 29, 2022 09:31
@dianashevchenko dianashevchenko added this to the 1.41.0 milestone Jul 29, 2022
@dianashevchenko dianashevchenko requested a review from a team as a code owner July 29, 2022 12:09
@dianashevchenko dianashevchenko changed the title added RTWithIgnoreOption to ignore outgoing requests contrib/net/http: Add new option to RoundTripper to ignore outgoing request Jul 29, 2022
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking great just one small nit for a comment

contrib/net/http/option.go Outdated Show resolved Hide resolved
ajgajg1134
ajgajg1134 previously approved these changes Jul 29, 2022
@dianashevchenko dianashevchenko merged commit 0dfa345 into main Aug 1, 2022
@dianashevchenko dianashevchenko deleted the shevchenko/roundtripper-ignore-option branch August 1, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contrib/net/http: Add new option to RoundTripper to ignore outgoing request
2 participants