Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec/waf: update libddwaf to v1.5.0 #1460

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Sep 9, 2022

Upgrade libddwaf to v1.5.0 - changelog at https://github.com/DataDog/libddwaf/releases/tag/1.5.0

@Julio-Guerra Julio-Guerra added this to the 1.43.0 milestone Sep 9, 2022
@Julio-Guerra Julio-Guerra requested a review from a team as a code owner September 9, 2022 10:17
@Julio-Guerra Julio-Guerra changed the title appsec/waf: update to libddwaf v1.5.0 appsec/waf: update libddwaf to v1.5.0 Sep 12, 2022
@Julio-Guerra Julio-Guerra modified the milestones: 1.43.0, 1.42.0 Sep 12, 2022
Copy link
Contributor

@Hellzy Hellzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

minor := uint16(v.minor)
patch := uint16(v.patch)
return fmt.Sprintf("%d.%d.%d", major, minor, patch)
cversion := C.ddwaf_get_version() // static mem pointer returned - no need to free it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could oneline this unless we'd rather keep it as is for debug purpose.

@Julio-Guerra Julio-Guerra merged commit 6c495a4 into main Sep 12, 2022
@Julio-Guerra Julio-Guerra deleted the julio.guerra/libddwaf-v1.5.0 branch September 12, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants