Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/net/http: don't set request path in Route field. #1471

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

bitterbit
Copy link
Contributor

Problem

http.route tag should contain the matched route template and not the full http path. This information is not available in the http.Handler struct thus I chose to remove this line instead of fixing the function to provide this data. If users want to send full http server information (including http.route) they should probably use NewServeMux() instead of WrapHandler

@bitterbit bitterbit added the bug unintended behavior that has to be fixed label Sep 19, 2022
@bitterbit bitterbit self-assigned this Sep 19, 2022
@bitterbit bitterbit requested a review from a team September 19, 2022 16:54
@knusbaum knusbaum changed the title Fix sending URL Path instead of http.route contrib/net/http: don't set request path in Route field. Sep 19, 2022
@knusbaum knusbaum added this to the 1.43.0 milestone Sep 19, 2022
@knusbaum
Copy link
Contributor

LGTM. Going to try kicking the CI.

@knusbaum knusbaum closed this Sep 19, 2022
@knusbaum knusbaum reopened this Sep 19, 2022
@knusbaum knusbaum merged commit 458a21b into main Sep 19, 2022
@knusbaum knusbaum deleted the galtashma/fix-http-route-in-wrap-handler branch September 19, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behavior that has to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants